Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore tests/lib/aclcheck_test.py from bd70bd #232

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Restore tests/lib/aclcheck_test.py from bd70bd #232

merged 1 commit into from
Feb 3, 2023

Conversation

jtwb
Copy link
Member

@jtwb jtwb commented Feb 3, 2023

No description provided.

@jtwb jtwb requested a review from ankenyr February 3, 2023 06:19
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 91.14% // Head: 90.88% // Decreases project coverage by -0.26% ⚠️

Coverage data is based on head (545998d) compared to base (eda6afb).
Patch coverage: 96.22% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   91.14%   90.88%   -0.26%     
==========================================
  Files          95       97       +2     
  Lines       21742    21949     +207     
  Branches     3265     3305      +40     
==========================================
+ Hits        19816    19948     +132     
- Misses       1256     1310      +54     
- Partials      670      691      +21     
Flag Coverage Δ
tests 90.86% <96.22%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/lib/aclcheck_test.py 96.22% <96.22%> (ø)
aerleon/lib/aclcheck.py 47.40% <0.00%> (ø)
aerleon/lib/port.py 35.63% <0.00%> (+9.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jtwb jtwb merged commit 71d1b70 into main Feb 3, 2023
@jtwb jtwb deleted the aclcheck_bttf branch February 3, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants