Skip NO_AF_LOG_ADDR when target=mixed #329
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #324
Aerleon will issue a warning when it finds a term where none of the match conditions are relevant for the current address family (the warning is called NO_AF_LOG_ADDR internally). However the code is too eager to generate this warning since the parent filter may have target=mixed, which is a two-pass process that ultimately will render these terms, making the warning inaccurate and unnecessary. This change removes that warning when target=mixed.