fix: move serialization of metrics data into mobile layer

pkg/dao/dao.go

@@ -2,24 +2,15 @@ package dao
 
 import (
 	"database/sql"
-	"encoding/json"
-
-	"github.com/aerogear/aerogear-metrics-api/pkg/mobile"
 )
 
 type MetricsDAO struct {
 	db *sql.DB
 }
 
 // Create a metrics record
-func (m *MetricsDAO) Create(metric mobile.Metric) error {
-	data, err := json.Marshal(metric.Data)
-
-	if err != nil {
-		return err
-	}
-
-	_, err = db.Exec("INSERT INTO mobileappmetrics(clientId, data) VALUES($1, $2)", metric.ClientId, data)
+func (m *MetricsDAO) Create(clientId string, metricsData []byte) error {
+	_, err := db.Exec("INSERT INTO mobileappmetrics(clientId, data) VALUES($1, $2)", clientId, metricsData)
 	return err
 }
 

pkg/mobile/interfaces.go

@@ -2,5 +2,5 @@ package mobile
 
 // MetricCreator defines how a metric can be created
 type MetricCreator interface {
-	Create(m Metric) error
+	Create(clientId string, metricsData []byte) error
 }

pkg/mobile/metrics.go

@@ -1,5 +1,7 @@
 package mobile
 
+import "encoding/json"
+
 type MetricsService struct {
 	mdao MetricCreator
 }
@@ -9,5 +11,12 @@ func NewMetricsService(dao MetricCreator) *MetricsService {
 }
 
 func (m MetricsService) Create(metric Metric) (Metric, error) {
-	return metric, m.mdao.Create(metric)
+
+	metricsData, err := json.Marshal(metric.Data)
+
+	if err != nil {
+		return metric, err
+	}
+
+	return metric, m.mdao.Create(metric.ClientId, metricsData)
 }