Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Golang Boilerplate Service #1

Merged
merged 17 commits into from
Feb 15, 2018
Merged

[WIP] Golang Boilerplate Service #1

merged 17 commits into from
Feb 15, 2018

Conversation

darahayes
Copy link
Contributor

@darahayes darahayes commented Feb 14, 2018

This is a work in progress. The code is structured with the philosophy that there is a clear separation between the business logic and the server logic.

Some things that still need to be done:

  • Finalize folder structure. I am aware that it's good practice to put the binary/entrypoint into a cmd folder
  • Decide on App configuration =. What configuration items should there be? e.g. DBConnectionString and also decide on how we should allow configuration. E.g. env variables, flags, config files. (personally I'm leaning towards env variables, envconfig looks pretty interesting.)
  • Need to figure out a good solution to logging.
  • testing - Right now there's a single blank test just to get the CircleCI stuff in place
  • refactor to pass by reference where appropriate. At the moment everything is passed by value. Certain things like app should definitely be passed by reference.
  • Better Docs (Readme and GoDocs)

@darahayes darahayes merged commit 0d90d34 into master Feb 15, 2018
@darahayes darahayes deleted the go-boilerplate branch February 15, 2018 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants