Initial Dockerfile Implementation #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@darahayes could you ping myself on PR's. It's good to have someone to take look. |
wtrocki
reviewed
Feb 16, 2018
| @@ -1,11 +1,17 @@ | |||
| FROM golang:latest | |||
There was a problem hiding this comment.
for community images we should use centos.
wtrocki
reviewed
Feb 16, 2018
|
|
||
| ADD . /aerogear-metrics-api | ||
| ADD . /go/src/github.com/aerogear/aerogear-metrics-api/ |
There was a problem hiding this comment.
While it's good to have that for regular docker support.
This is not openshift way of doing things.
If we want to build image from source we could use golang s2i.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.