AGSMPLPUSH-49 "Greeting message is only returned once."

netty-codec-sockjs/src/main/java/org/jboss/aerogear/io/netty/handler/codec/sockjs/handler/Greeting.java

@@ -42,7 +42,10 @@ public static boolean matches(final String path) {
     }
 
     public static FullHttpResponse response(final HttpRequest request) {
-        final FullHttpResponse response = new DefaultFullHttpResponse(request.getProtocolVersion(), OK, CONTENT);
+        final FullHttpResponse response = new DefaultFullHttpResponse(
+                request.getProtocolVersion(),
+                OK,
+                CONTENT.duplicate());
         response.headers().set(CONTENT_TYPE, Transports.CONTENT_TYPE_PLAIN);
         return response;
     }

netty-codec-sockjs/src/test/java/org/jboss/aerogear/io/netty/handler/codec/sockjs/handler/GreetingTest.java

@@ -15,23 +15,43 @@
  */
 package org.jboss.aerogear.io.netty.handler.codec.sockjs.handler;
 
-import static org.hamcrest.CoreMatchers.equalTo;
-import static org.hamcrest.MatcherAssert.assertThat;
+import io.netty.channel.embedded.EmbeddedChannel;
 import io.netty.handler.codec.http.DefaultFullHttpRequest;
 import io.netty.handler.codec.http.FullHttpResponse;
 import io.netty.handler.codec.http.HttpMethod;
 import io.netty.handler.codec.http.HttpRequest;
+import io.netty.handler.codec.http.HttpResponseEncoder;
 import io.netty.handler.codec.http.HttpVersion;
 import io.netty.util.CharsetUtil;
-
-import org.jboss.aerogear.io.netty.handler.codec.sockjs.handler.Greeting;
 import org.junit.Test;
 
+import static org.hamcrest.CoreMatchers.*;
+import static org.hamcrest.MatcherAssert.*;
+
 public class GreetingTest {
 
     @Test
     public void greeting() throws Exception {
-        final FullHttpResponse response = Greeting.response(createHttpRequest("/simplepush"));
+        final FullHttpResponse response = sendGreetingRequest();
+        assertWelcomeMessage(response);
+    }
+
+    @Test
+    public void greetingThroughDecoder() throws Exception {
+        final EmbeddedChannel ch = new EmbeddedChannel(new HttpResponseEncoder());
+        final FullHttpResponse response = sendGreetingRequest();
+        assertWelcomeMessage(response);
+        // send response through HttpResponseEncoder
+        ch.writeOutbound(response);
+        final FullHttpResponse response2 = sendGreetingRequest();
+        assertWelcomeMessage(response2);
+    }
+
+    private FullHttpResponse sendGreetingRequest() {
+        return Greeting.response(createHttpRequest("/simplepush"));
+    }
+
+    private void assertWelcomeMessage(final FullHttpResponse response) {
         assertThat(response.content().toString(CharsetUtil.UTF_8), equalTo("Welcome to SockJS!\n"));
         response.release();
     }