Skip to content
This repository has been archived by the owner on Nov 18, 2018. It is now read-only.

AGSMPLPUSH-56 : make the vertx server compliant for OpenShift deployments #80

Closed

Conversation

sebastienblanc
Copy link

No description provided.

@danbev
Copy link
Contributor

danbev commented Apr 23, 2014

I'm 👎 on this I'm afraid.
I'd prefer not to have OpenShift specific variables in the code base. @sebastienblanc as we discussed on IRC you might have an optional solution for this where we could instead add two configuration options, endpoint-host and endpoint-port similar to what we do for the Netty version of SimplePush Server. Does that make sense?

@matzew
Copy link
Contributor

matzew commented Apr 24, 2014

I agree w/ @danbev

@danbev
Copy link
Contributor

danbev commented Apr 29, 2014

@sebastienblanc I'm closing this for the time being as it might not make it into the next release. But please feel free to create a new PR or re-open later when there is support for this from the vert.x side, or if you have a workaround for OpenShift which would enable the existing config.json file. Thx

@danbev danbev closed this Apr 29, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants