-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added create params to the table #31
Conversation
pkg/cmd/services.go
Outdated
@@ -69,6 +69,14 @@ func (sc *ServicesCmd) ListServicesCmd() *cobra.Command { | |||
return nil | |||
}, | |||
} | |||
|
|||
type params struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there is already a type defined for this in that file. It is called instanceCreateParams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maleck13 it is, but we needed to make this change Properties map[string]map[string]interface{}
otherwise it would not unmarshal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok well then I think update the instanceCreateParams to be the same and remove the extra type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maleck13 done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor change
Also I wonder would it be possible to add a newline after each set of params. Might improve how it looks? |
We tried that, I ll look into it again but I think that the table writer is preventing this. |
@maleck13 tablewriter removes |
27b5513
to
9bd0ebc
Compare
9bd0ebc
to
79a76ca
Compare
Describe what this PR does and why we need it:
Changes proposed in this pull request
mobile get services