Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added create params to the table #31

Merged
merged 1 commit into from
Jan 15, 2018
Merged

added create params to the table #31

merged 1 commit into from
Jan 15, 2018

Conversation

witmicko
Copy link
Contributor

Describe what this PR does and why we need it:

Changes proposed in this pull request

  • added create params to the table output of mobile get services
+------------------------+---------------------+------------------+--------------------------------+----------------------------------+
|           ID           |        NAME         |   INTEGRATIONS   |           PARAMETERS           |              CLASS               |
+------------------------+---------------------+------------------+--------------------------------+----------------------------------+
| dh-unifiedpush-apb     | ups                 |                  | MYSQL_ROOT_PASSWORD,           | 1522a4d0e2fbf86a26cbe096eb1b6b2d |
|                        |                     |                  | MYSQL_USER, MYSQL_VERSION,     |                                  |
|                        |                     |                  | MYSQL_DATABASE, MYSQL_PASSWORD |                                  |
| dh-3scale-apb          | 3scale              |                  | THREESCALE_ENABLE_CORS,        | 2b825339e8d685a78476621a252beea8 |
|                        |                     |                  | THREESCALE_SERVICE_ID,         |                                  |
|                        |                     |                  | THREESCALE_ACCESS_TOKEN,       |                                  |
|                        |                     |                  | THREESCALE_DOMAIN              |                                  |
| dh-metrics-apb         | prometheus          |                  | GRAFANA_STORAGE_SIZE,          | 9623d53183cc78619f888ea8499c678e |
|                        |                     |                  | PROMETHEUS_STORAGE_SIZE        |                                  |
| dh-aerogear-digger-apb | aerogear-digger-apb |                  | ANDROID_LICENSE_AGREEMENT      | a0c0c2478554458d5c77abc95f0473a3 |
| dh-keycloak-apb        | keycloak            |                  | ADMIN_NAME, ADMIN_PASSWORD     | b95513950bb3f132de25d58fb75f8dca |
| dh-fh-sync-server-apb  | fh-sync-server      | keycloak,apiKeys | MONGODB_USER_PASSWORD,         | c57e94c36c1e7f6bb41cf7c589d9eb08 |
|                        |                     |                  | MONGODB_ADMIN_PASSWORD,        |                                  |
|                        |                     |                  | MONGODB_USER_NAME              |                                  |
+------------------------+---------------------+------------------+--------------------------------+----------------------------------+

@@ -69,6 +69,14 @@ func (sc *ServicesCmd) ListServicesCmd() *cobra.Command {
return nil
},
}

type params struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there is already a type defined for this in that file. It is called instanceCreateParams

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maleck13 it is, but we needed to make this change Properties map[string]map[string]interface{} otherwise it would not unmarshal

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok well then I think update the instanceCreateParams to be the same and remove the extra type

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maleck13 done

Copy link
Contributor

@maleck13 maleck13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor change

@maleck13
Copy link
Contributor

Also I wonder would it be possible to add a newline after each set of params. Might improve how it looks?

@witmicko
Copy link
Contributor Author

Also I wonder would it be possible to add a newline after each set of params. Might improve how it looks?

We tried that, I ll look into it again but I think that the table writer is preventing this.

@witmicko
Copy link
Contributor Author

Also I wonder would it be possible to add a newline after each set of params. Might improve how it looks?

@maleck13 tablewriter removes \n so at the moment we cannot separate the parameters by newline
https://github.com/olekukonko/tablewriter/blob/master/wrap.go#L27

@witmicko witmicko merged commit c02f54b into master Jan 15, 2018
@witmicko witmicko deleted the AEROGEAR-1861 branch January 15, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants