Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] new project per build #65

Merged
merged 1 commit into from
Feb 6, 2018
Merged

[WIP] new project per build #65

merged 1 commit into from
Feb 6, 2018

Conversation

philbrookes
Copy link
Contributor

No description provided.

@AdamSaleh
Copy link
Contributor

Almost works. Looks like more normalization on that goldenfile is needed, i.e.
Keycloak service seems to have different externalID in its spec.

AdamSaleh
AdamSaleh approved these changes Feb 6, 2018
View reviewed changes
Copy link
Contributor

@AdamSaleh AdamSaleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, this seems to be a good way to do the integration tests.

@philbrookes philbrookes merged commit 2506eb9 into aerogear-attic:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamSaleh AdamSaleh AdamSaleh approved these changes

@psturc psturc psturc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@philbrookes @AdamSaleh @psturc