Conversation
make the login endpoint works again
@edewit running
deployed also on 👍 |
@sebastienblanc @danielpassos care to take a look as well |
@cvasilak thanks |
Deployed on wildfly-8.1.0.Final and created a lead without problem. Buuuuuuuuuut. I think I get a problem. When I try login using wrong login/pass. The console display login failed
Buuuuuuuuuut the form was replaced for Logout button :/ |
@sebastienblanc can you take a look here ? |
I will also review it today and merge after @sebastienblanc comments |
@edewit would you mind to take a look at the issue reported by @danielpassos if possible? |
@abstractj sure I'm on it |
@danielpassos can't reproduce the problem that you have I'm using wildfly-8.1.0-Final and after I login I get the leads list and I don't see the log with the failure. Are you using a different version? |
@cvasilak it seems that you no problem logging in right? |
@edewit similar behaviour with passos, if wrong credentials are provided, the button is replaced with Logout but in the console I am getting:
|
@cvasilak @danielpassos ahh, sorry fixed it now, though I doubt that this PR introduced that 435c21a |
@edewit that fixed the issue but noticed sth else. |
adding the content type e7cf2e7 fixes the logout problem |
after the latest change, tested and the logout issue is fixed now 👍 to merge |
tested on WF 8.1 and could also send out message to latest UPS and 0.10.x on Openshift |
On JBoss AS.7.1.1 I am getting:
not sure if that's a priority or not - I am fine in making AeroDoc supporting WF8.x and later. but that should be perhaps discussed on the ML, instead of here... |
Right now we changed it to work only on wildfly, we can change it to add On Mon, Aug 18, 2014 at 4:42 PM, Matthias Wessendorf <
|
I am fine w/ only WildFly, but understood this fix differently (e.g. WF and On Mon, Aug 18, 2014 at 7:44 PM, Erik Jan de Wit notifications@github.com
Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ |
I think w/ this fix only WF is supported, since I get runtime errors on I think these are the options:
On Monday, August 18, 2014, Bruno Oliveira notifications@github.com wrote:
Sent from Gmail Mobile |
</dependency> | ||
</dependencies> | ||
</profile> | ||
<profile> | ||
<id>jbossas</id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to activate one profile, on default ? e.g. wildfly ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default profile is used for the arquillian tests
running
looks like the hibernate-search is missing in that 'default' profile. Not sure, but perhaps we should make the |
Looks like Travis has the same error |
using the -Pwildfly profile, I get these test errors: using the -Pjboss7 profile, I get these test errors: |
right, need to skip the tests when building the wildfly or jboss7 wars |
that feels wrong On Tue, Aug 19, 2014 at 10:00 AM, Erik Jan de Wit notifications@github.com
Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ |
forget about this then |
what should we do instead? I am just wondering why one needs to skip tests On Tue, Aug 19, 2014 at 10:08 AM, Erik Jan de Wit notifications@github.com
Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ |
Okay how about this we create per default a jboss7 war and run the arquillian tests. When you want a wildfly war file we skip the tests and create a wildfly war |
sounds good with me! What I liked on the WF profile, the pom.xml did the skip tests already -> I like this suggestion On Tue, Aug 19, 2014 at 10:21 AM, Erik Jan de Wit notifications@github.com
Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ |
👍 on this! I have tested both variants:
|
deployed on both wildfly using 👍 |
landed in 531e45c |
now works on wildfly