Skip to content
This repository has been archived by the owner on Dec 5, 2019. It is now read-only.

Agpush 503 #43

Merged
merged 11 commits into from Aug 20, 2014
Merged

Agpush 503 #43

merged 11 commits into from Aug 20, 2014

Conversation

edewit
Copy link
Contributor

@edewit edewit commented Aug 5, 2014

now works on wildfly

@cvasilak
Copy link
Contributor

cvasilak commented Aug 6, 2014

@edewit running mvn clean install didn't give me any errors:

Tests run: 5, Failures: 0, Errors: 0, Skipped: 0

deployed also on wildfly-8.1.0.Final, created lead from the webapp and correctly received notifs in iOS aerodoc client.

👍

@edewit
Copy link
Contributor Author

edewit commented Aug 6, 2014

@sebastienblanc @danielpassos care to take a look as well

@edewit
Copy link
Contributor Author

edewit commented Aug 6, 2014

@cvasilak thanks

@danielpassos
Copy link
Contributor

mvn clean package works.

Deployed on wildfly-8.1.0.Final and created a lead without problem.

Buuuuuuuuuut. I think I get a problem.

When I try login using wrong login/pass. The console display login failed

21:27:03,304 INFO  [Login] (default task-45) Login result : FAILED
21:27:03,305 SEVERE [Login] (default task-45) Login failed !

Buuuuuuuuuut the form was replaced for Logout button :/

@matzew
Copy link
Contributor

matzew commented Aug 7, 2014

@sebastienblanc can you take a look here ?

@abstractj
Copy link
Contributor

I will also review it today and merge after @sebastienblanc comments

@abstractj
Copy link
Contributor

@edewit would you mind to take a look at the issue reported by @danielpassos if possible?

@edewit
Copy link
Contributor Author

edewit commented Aug 12, 2014

@abstractj sure I'm on it

@edewit
Copy link
Contributor Author

edewit commented Aug 12, 2014

@danielpassos can't reproduce the problem that you have I'm using wildfly-8.1.0-Final and after I login I get the leads list and I don't see the log with the failure. Are you using a different version?

@edewit
Copy link
Contributor Author

edewit commented Aug 12, 2014

@cvasilak it seems that you no problem logging in right?

@cvasilak
Copy link
Contributor

@edewit similar behaviour with passos, if wrong credentials are provided, the button is replaced with Logout but in the console I am getting:

08:38:08,861 INFO  [Login] (default task-5) Login result : FAILED
08:38:08,862 SEVERE [Login] (default task-5) Login failed !

@edewit
Copy link
Contributor Author

edewit commented Aug 13, 2014

@cvasilak @danielpassos ahh, sorry fixed it now, though I doubt that this PR introduced that 435c21a

@cvasilak
Copy link
Contributor

@edewit that fixed the issue but noticed sth else.
If you login, you can view/edit leads/push configs, then click logout but.. you can still continue adding leads/pushconfigs even if you have logged out. Further, you cannot re-login, getting "Not Authorized" even if the credentials are correct :(

@danielpassos
Copy link
Contributor

@cvasilak Good catch. @edewit Same here

@edewit
Copy link
Contributor Author

edewit commented Aug 18, 2014

adding the content type e7cf2e7 fixes the logout problem

@cvasilak
Copy link
Contributor

after the latest change, tested and the logout issue is fixed now

👍 to merge

@matzew
Copy link
Contributor

matzew commented Aug 18, 2014

tested on WF 8.1 and could also send out message to latest UPS and 0.10.x on Openshift

@matzew
Copy link
Contributor

matzew commented Aug 18, 2014

On JBoss AS.7.1.1 I am getting:

Caused by: java.lang.NoClassDefFoundError: org/hibernate/search/impl/FullTextSessionImpl
    at org.hibernate.search.Search.getFullTextSession(Search.java:45) [hibernate-search-orm-4.5.1.Final.jar:4.5.1.Final]
    at org.hibernate.search.jpa.impl.FullTextEntityManagerImpl.getFullTextSession(FullTextEntityManagerImpl.java:81) [hibernate-search-orm-4.5.1.Final.jar:4.5.1.Final]
    at org.hibernate.search.jpa.impl.FullTextEntityManagerImpl.getSearchFactory(FullTextEntityManagerImpl.java:122) [hibernate-search-orm-4.5.1.Final.jar:4.5.1.Final]
    at org.jboss.aerogear.aerodoc.rest.SaleAgentEndpoint.listByCriteria(SaleAgentEndpoint.java:160) [classes:]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [rt.jar:1.7.0_65]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) [rt.jar:1.7.0_65]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [rt.jar:1.7.0_65]
    at java.lang.reflect.Method.invoke(Method.java:606) [rt.jar:1.7.0_65]
    at org.jboss.as.ee.component.ManagedReferenceMethodInterceptorFactory$ManagedReferenceMethodInterceptor.processInvocation(ManagedReferenceMethodInterceptorFactory.java:72) [jboss-as-ee-7.1.1.Final.jar:7.1.1.Final]
    at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:288) [jboss-invocation-1.1.1.Final.jar:1.1.1.Final]
    at org.jboss.invocation.InterceptorContext$Invocation.proceed(InterceptorContext.java:374) [jboss-invocation-1.1.1.Final.jar:1.1.1.Final]
    at org.jboss.as.weld.ejb.DelegatingInterceptorInvocationContext.proceed(DelegatingInterceptorInvocationContext.java:81) [jboss-as-weld-7.1.1.Final.jar:7.1.1.Final]
    at org.apache.deltaspike.security.impl.extension.DefaultSecurityStrategy.execute(DefaultSecurityStrategy.java:64) [picketlink-2.6.1.Final.jar:]
    at org.apache.deltaspike.security.impl.extension.SecurityInterceptor.filterDeniedInvocations(SecurityInterceptor.java:44) [picketlink-2.6.1.Final.jar:]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [rt.jar:1.7.0_65]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) [rt.jar:1.7.0_65]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [rt.jar:1.7.0_65]
    at java.lang.reflect.Method.invoke(Method.java:606) [rt.jar:1.7.0_65]
    at org.jboss.interceptor.proxy.InterceptorInvocation$InterceptorMethodInvocation.invoke(InterceptorInvocation.java:72) [jboss-interceptor-core-2.0.0.Final.jar:2.0.0.Final]
    at org.jboss.interceptor.proxy.SimpleInterceptionChain.invokeNextInterceptor(SimpleInterceptionChain.java:82) [jboss-interceptor-core-2.0.0.Final.jar:2.0.0.Final]
    at org.jboss.weld.bean.InterceptorImpl.intercept(InterceptorImpl.java:90) [weld-core-1.1.5.AS71.Final.jar:2012-02-10 15:31]

not sure if that's a priority or not - I am fine in making AeroDoc supporting WF8.x and later.

but that should be perhaps discussed on the ML, instead of here...

@edewit
Copy link
Contributor Author

edewit commented Aug 18, 2014

Right now we changed it to work only on wildfly, we can change it to add
profiles to work on both.

On Mon, Aug 18, 2014 at 4:42 PM, Matthias Wessendorf <
notifications@github.com> wrote:

On JBoss AS.7.1.1 I am getting:

Caused by: java.lang.NoClassDefFoundError: org/hibernate/search/impl/FullTextSessionImpl
at org.hibernate.search.Search.getFullTextSession(Search.java:45) [hibernate-search-orm-4.5.1.Final.jar:4.5.1.Final]
at org.hibernate.search.jpa.impl.FullTextEntityManagerImpl.getFullTextSession(FullTextEntityManagerImpl.java:81) [hibernate-search-orm-4.5.1.Final.jar:4.5.1.Final]
at org.hibernate.search.jpa.impl.FullTextEntityManagerImpl.getSearchFactory(FullTextEntityManagerImpl.java:122) [hibernate-search-orm-4.5.1.Final.jar:4.5.1.Final]
at org.jboss.aerogear.aerodoc.rest.SaleAgentEndpoint.listByCriteria(SaleAgentEndpoint.java:160) [classes:]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [rt.jar:1.7.0_65]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) [rt.jar:1.7.0_65]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [rt.jar:1.7.0_65]
at java.lang.reflect.Method.invoke(Method.java:606) [rt.jar:1.7.0_65]
at org.jboss.as.ee.component.ManagedReferenceMethodInterceptorFactory$ManagedReferenceMethodInterceptor.processInvocation(ManagedReferenceMethodInterceptorFactory.java:72) [jboss-as-ee-7.1.1.Final.jar:7.1.1.Final]
at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:288) [jboss-invocation-1.1.1.Final.jar:1.1.1.Final]
at org.jboss.invocation.InterceptorContext$Invocation.proceed(InterceptorContext.java:374) [jboss-invocation-1.1.1.Final.jar:1.1.1.Final]
at org.jboss.as.weld.ejb.DelegatingInterceptorInvocationContext.proceed(DelegatingInterceptorInvocationContext.java:81) [jboss-as-weld-7.1.1.Final.jar:7.1.1.Final]
at org.apache.deltaspike.security.impl.extension.DefaultSecurityStrategy.execute(DefaultSecurityStrategy.java:64) [picketlink-2.6.1.Final.jar:]
at org.apache.deltaspike.security.impl.extension.SecurityInterceptor.filterDeniedInvocations(SecurityInterceptor.java:44) [picketlink-2.6.1.Final.jar:]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [rt.jar:1.7.0_65]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) [rt.jar:1.7.0_65]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [rt.jar:1.7.0_65]
at java.lang.reflect.Method.invoke(Method.java:606) [rt.jar:1.7.0_65]
at org.jboss.interceptor.proxy.InterceptorInvocation$InterceptorMethodInvocation.invoke(InterceptorInvocation.java:72) [jboss-interceptor-core-2.0.0.Final.jar:2.0.0.Final]
at org.jboss.interceptor.proxy.SimpleInterceptionChain.invokeNextInterceptor(SimpleInterceptionChain.java:82) [jboss-interceptor-core-2.0.0.Final.jar:2.0.0.Final]
at org.jboss.weld.bean.InterceptorImpl.intercept(InterceptorImpl.java:90) [weld-core-1.1.5.AS71.Final.jar:2012-02-10 15:31]

not sure if that's a priority or not - I am fine in making AeroDoc
supporting WF8.x and later.

but that should be perhaps discussed on the ML, instead of here...


Reply to this email directly or view it on GitHub
#43 (comment)
.

@matzew
Copy link
Contributor

matzew commented Aug 18, 2014

Right now we changed it to work only on wildfly

I am fine w/ only WildFly, but understood this fix differently (e.g. WF and
AS7).
I noticed in the tests (arquillian?) the AS7 is started. If we target only
WF, we should fix that I think.

On Mon, Aug 18, 2014 at 7:44 PM, Erik Jan de Wit notifications@github.com
wrote:

Right now we changed it to work only on wildfly, we can change it to add
profiles to work on both.

On Mon, Aug 18, 2014 at 4:42 PM, Matthias Wessendorf <
notifications@github.com> wrote:

On JBoss AS.7.1.1 I am getting:

Caused by: java.lang.NoClassDefFoundError:
org/hibernate/search/impl/FullTextSessionImpl
at org.hibernate.search.Search.getFullTextSession(Search.java:45)
[hibernate-search-orm-4.5.1.Final.jar:4.5.1.Final]
at
org.hibernate.search.jpa.impl.FullTextEntityManagerImpl.getFullTextSession(FullTextEntityManagerImpl.java:81)
[hibernate-search-orm-4.5.1.Final.jar:4.5.1.Final]
at
org.hibernate.search.jpa.impl.FullTextEntityManagerImpl.getSearchFactory(FullTextEntityManagerImpl.java:122)
[hibernate-search-orm-4.5.1.Final.jar:4.5.1.Final]
at
org.jboss.aerogear.aerodoc.rest.SaleAgentEndpoint.listByCriteria(SaleAgentEndpoint.java:160)
[classes:]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[rt.jar:1.7.0_65]
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
[rt.jar:1.7.0_65]
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[rt.jar:1.7.0_65]
at java.lang.reflect.Method.invoke(Method.java:606) [rt.jar:1.7.0_65]
at
org.jboss.as.ee.component.ManagedReferenceMethodInterceptorFactory$ManagedReferenceMethodInterceptor.processInvocation(ManagedReferenceMethodInterceptorFactory.java:72)
[jboss-as-ee-7.1.1.Final.jar:7.1.1.Final]
at
org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:288)
[jboss-invocation-1.1.1.Final.jar:1.1.1.Final]
at
org.jboss.invocation.InterceptorContext$Invocation.proceed(InterceptorContext.java:374)
[jboss-invocation-1.1.1.Final.jar:1.1.1.Final]
at
org.jboss.as.weld.ejb.DelegatingInterceptorInvocationContext.proceed(DelegatingInterceptorInvocationContext.java:81)
[jboss-as-weld-7.1.1.Final.jar:7.1.1.Final]
at
org.apache.deltaspike.security.impl.extension.DefaultSecurityStrategy.execute(DefaultSecurityStrategy.java:64)
[picketlink-2.6.1.Final.jar:]
at
org.apache.deltaspike.security.impl.extension.SecurityInterceptor.filterDeniedInvocations(SecurityInterceptor.java:44)
[picketlink-2.6.1.Final.jar:]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[rt.jar:1.7.0_65]
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
[rt.jar:1.7.0_65]
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[rt.jar:1.7.0_65]
at java.lang.reflect.Method.invoke(Method.java:606) [rt.jar:1.7.0_65]
at
org.jboss.interceptor.proxy.InterceptorInvocation$InterceptorMethodInvocation.invoke(InterceptorInvocation.java:72)
[jboss-interceptor-core-2.0.0.Final.jar:2.0.0.Final]
at
org.jboss.interceptor.proxy.SimpleInterceptionChain.invokeNextInterceptor(SimpleInterceptionChain.java:82)
[jboss-interceptor-core-2.0.0.Final.jar:2.0.0.Final]
at
org.jboss.weld.bean.InterceptorImpl.intercept(InterceptorImpl.java:90)
[weld-core-1.1.5.AS71.Final.jar:2012-02-10 15:31]

not sure if that's a priority or not - I am fine in making AeroDoc
supporting WF8.x and later.

but that should be perhaps discussed on the ML, instead of here...


Reply to this email directly or view it on GitHub
<
https://github.com/aerogear/aerogear-aerodoc-backend/pull/43#issuecomment-52510543>

.


Reply to this email directly or view it on GitHub
#43 (comment)
.

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

@abstractj
Copy link
Contributor

@matzew @edewit as far as I can tell we support both, right? Otherwise we need to change all of our projects/documentation to state the WildFly only support, for the sake of consistency.

@matzew
Copy link
Contributor

matzew commented Aug 18, 2014

I think w/ this fix only WF is supported, since I get runtime errors on
AS7.1.1

I think these are the options:

  • WF and AS7 (via profiles)
  • WF only, which requires updates (e.g docs, tests etc) and perhaps a
    heads-up to the mailing list

On Monday, August 18, 2014, Bruno Oliveira notifications@github.com wrote:

@matzew https://github.com/matzew @edewit https://github.com/edewit
as far as I can tell we support both, right? Otherwise we need to change
all of our projects/documentation to state the WildFly only support, for
the sake of consistency.


Reply to this email directly or view it on GitHub
#43 (comment)
.

Sent from Gmail Mobile

</dependency>
</dependencies>
</profile>
<profile>
<id>jbossas</id>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to activate one profile, on default ? e.g. wildfly ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default profile is used for the arquillian tests

@matzew
Copy link
Contributor

matzew commented Aug 19, 2014

running mvn clean install gives me this error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) on project aerodoc: Compilation failure: Compilation failure:
[ERROR] bootstrap class path not set in conjunction with -source 1.6
[ERROR] /Users/matzew/TEMP/AGPUSH-503/src/main/java/org/jboss/aerogear/aerodoc/rest/SaleAgentEndpoint.java:[19,31] error: package org.hibernate.search.jpa does not exist
[ERROR] /Users/matzew/TEMP/AGPUSH-503/src/main/java/org/jboss/aerogear/aerodoc/rest/SaleAgentEndpoint.java:[20,31] error: package org.hibernate.search.jpa does not exist
[ERROR] /Users/matzew/TEMP/AGPUSH-503/src/main/java/org/jboss/aerogear/aerodoc/rest/SaleAgentEndpoint.java:[21,37] error: package org.hibernate.search.query.dsl does not exist
[ERROR] /Users/matzew/TEMP/AGPUSH-503/src/main/java/org/jboss/aerogear/aerodoc/rest/SaleAgentEndpoint.java:[22,37] error: package org.hibernate.search.query.dsl does not exist
[ERROR] /Users/matzew/TEMP/AGPUSH-503/src/main/java/org/jboss/aerogear/aerodoc/model/SaleAgent.java:[19,36] error: package org.codehaus.jackson.annotate does not exist
[ERROR] /Users/matzew/TEMP/AGPUSH-503/src/main/java/org/jboss/aerogear/aerodoc/model/SaleAgent.java:[27,1] error: cannot find symbol
[ERROR] /Users/matzew/TEMP/AGPUSH-503/src/main/java/org/jboss/aerogear/aerodoc/model/entity/SalesAgentEntity.java:[19,39] error: package org.hibernate.search.annotations does not exist
[ERROR] /Users/matzew/TEMP/AGPUSH-503/src/main/java/org/jboss/aerogear/aerodoc/model/entity/SalesAgentEntity.java:[20,39] error: package org.hibernate.search.annotations does not exist
[ERROR] /Users/matzew/TEMP/AGPUSH-503/src/main/java/org/jboss/aerogear/aerodoc/model/entity/SalesAgentEntity.java:[21,39] error: package org.hibernate.search.annotations does not exist
[ERROR] /Users/matzew/TEMP/AGPUSH-503/src/main/java/org/jboss/aerogear/aerodoc/model/entity/SalesAgentEntity.java:[22,39] error: package org.hibernate.search.annotations does not exist
[ERROR] /Users/matzew/TEMP/AGPUSH-503/src/main/java/org/jboss/aerogear/aerodoc/model/entity/SalesAgentEntity.java:[36,1] error: cannot find symbol
[ERROR] class Spatial
[ERROR] /Users/matzew/TEMP/AGPUSH-503/src/main/java/org/jboss/aerogear/aerodoc/model/entity/SalesAgentEntity.java:[37,1] error: cannot find symbol
[ERROR] class Indexed
[ERROR] /Users/matzew/TEMP/AGPUSH-503/src/main/java/org/jboss/aerogear/aerodoc/model/entity/SalesAgentEntity.java:[60,5] error: cannot find symbol
[ERROR] class SalesAgentEntity
[ERROR] /Users/matzew/TEMP/AGPUSH-503/src/main/java/org/jboss/aerogear/aerodoc/model/entity/SalesAgentEntity.java:[64,5] error: cannot find symbol
[ERROR] class SalesAgentEntity
[ERROR] /Users/matzew/TEMP/AGPUSH-503/src/main/java/org/jboss/aerogear/aerodoc/rest/SaleAgentEndpoint.java:[159,6] error: cannot find symbol
[ERROR] class SaleAgentEndpoint
[ERROR] /Users/matzew/TEMP/AGPUSH-503/src/main/java/org/jboss/aerogear/aerodoc/rest/SaleAgentEndpoint.java:[159,39] error: cannot find symbol
[ERROR] class SaleAgentEndpoint
[ERROR] /Users/matzew/TEMP/AGPUSH-503/src/main/java/org/jboss/aerogear/aerodoc/rest/SaleAgentEndpoint.java:[160,6] error: cannot find symbol
[ERROR] class SaleAgentEndpoint
[ERROR] /Users/matzew/TEMP/AGPUSH-503/src/main/java/org/jboss/aerogear/aerodoc/rest/SaleAgentEndpoint.java:[163,30] error: package org.apache.lucene.search does not exist
[ERROR] /Users/matzew/TEMP/AGPUSH-503/src/main/java/org/jboss/aerogear/aerodoc/rest/SaleAgentEndpoint.java:[165,26] error: cannot find symbol
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

looks like the hibernate-search is missing in that 'default' profile. Not sure, but perhaps we should make the jboss7 the default profile - instead of the current jbossas profile ?

@matzew
Copy link
Contributor

matzew commented Aug 19, 2014

Looks like Travis has the same error

@matzew
Copy link
Contributor

matzew commented Aug 19, 2014

using the -Pwildfly profile, I get these test errors:
https://gist.github.com/matzew/d3f54f9389a64f7cf719

using the -Pjboss7 profile, I get these test errors:
https://gist.github.com/matzew/b7514e4a3d9402d1100b

@edewit
Copy link
Contributor Author

edewit commented Aug 19, 2014

right, need to skip the tests when building the wildfly or jboss7 wars

@matzew
Copy link
Contributor

matzew commented Aug 19, 2014

that feels wrong

On Tue, Aug 19, 2014 at 10:00 AM, Erik Jan de Wit notifications@github.com
wrote:

right, need to skip the tests when building the wildfly or jboss7 wars


Reply to this email directly or view it on GitHub
#43 (comment)
.

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

@edewit
Copy link
Contributor Author

edewit commented Aug 19, 2014

forget about this then

@edewit edewit closed this Aug 19, 2014
@matzew
Copy link
Contributor

matzew commented Aug 19, 2014

what should we do instead? I am just wondering why one needs to skip tests
for building a WAR file

On Tue, Aug 19, 2014 at 10:08 AM, Erik Jan de Wit notifications@github.com
wrote:

forget about this then


Reply to this email directly or view it on GitHub
#43 (comment)
.

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

@edewit
Copy link
Contributor Author

edewit commented Aug 19, 2014

Okay how about this we create per default a jboss7 war and run the arquillian tests. When you want a wildfly war file we skip the tests and create a wildfly war

@matzew
Copy link
Contributor

matzew commented Aug 19, 2014

sounds good with me!

What I liked on the WF profile, the pom.xml did the skip tests already ->
no extra work for the user.
For the readme, I think one little sentence on why skipping the tests
should be good enough as well

I like this suggestion

On Tue, Aug 19, 2014 at 10:21 AM, Erik Jan de Wit notifications@github.com
wrote:

Okay how about this we create per default a jboss7 war and run the
arquillian tests. When you want a wildfly war file we skip the tests and
create a wildfly war


Reply to this email directly or view it on GitHub
#43 (comment)
.

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

@edewit
Copy link
Contributor Author

edewit commented Aug 19, 2014

okay 9ab7327 and bbfc017

@edewit edewit reopened this Aug 19, 2014
@matzew
Copy link
Contributor

matzew commented Aug 19, 2014

👍 on this!

I have tested both variants:

  • mvn clean install -Pwildfly and copied the WAR to WF8.1 -> works perfect (deployment and the app itself)
  • mvn clean install and copied the WAR to AS7.1.1 -> works perfect (deployment and the app itself)

@cvasilak
Copy link
Contributor

deployed on both wildfly using mvn clean install -Pwildfly and jbossas7 using mvn clean install and the app deployed successfully and worked

👍

@matzew matzew merged commit bbfc017 into aerogear-attic:master Aug 20, 2014
@matzew
Copy link
Contributor

matzew commented Aug 20, 2014

landed in 531e45c

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants