Registrations #15

secondsun · 2014-10-07T20:36:33Z

Needs AeroGear Android Core
Should mvn clean install.

Need to update quickstart for more demo testing.

Helloworld demo : https://github.com/secondsun/aerogear-push-helloworld/tree/registrations

secondsun · 2014-10-07T20:36:52Z

@danielpassos @cvasilak care to take a look?

matzew · 2014-10-08T06:02:28Z

@secondsun what's the JIRA for this?

secondsun · 2014-10-08T11:00:54Z

https://issues.jboss.org/browse/AGDROID-296

matzew · 2014-10-08T12:31:16Z

...r-android-push/src/org/jboss/aerogear/android/impl/unifiedpush/AeroGearGCMPushRegistrar.java

+     * Default lifespan (7 days) of a reservation until it is considered
+     * expired.
+     */
+    public static final long REGISTRATION_EXPIRY_TIME_MS = 1000 * 3600 * 24 * 7;


what is this for?

It is the default lifetime for a registration.

It is the default lifetime for a registration.

for a registrationId on GCM? Does that mean after 7 days, I get a new
registrationID?

On Wed, Oct 8, 2014 at 3:05 PM, Hoyt Summers Pittman <
notifications@github.com> wrote:

In
aerogear-android-push/src/org/jboss/aerogear/android/impl/unifiedpush/AeroGearGCMPushRegistrar.java:

public class AeroGearGCMPushRegistrar implements PushRegistrar {

private static final Integer TIMEOUT = 30000;//30 seconds

/**

\* Default lifespan (7 days) of a reservation until it is considered

\* expired.

*/

public static final long REGISTRATION_EXPIRY_TIME_MS = 1000 * 3600 * 24 * 7;

It is the default lifetime for a registration.

—
Reply to this email directly or view it on GitHub
https://github.com/aerogear/aerogear-android-push/pull/15/files#r18580331
.

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

matzew · 2014-10-08T12:39:02Z

running mvn clean install works only if I have an online device connect to my machine...

secondsun · 2014-10-08T13:07:00Z

@matzew
Yes that is true for literally every one of the android projects.

sebastienblanc · 2014-10-08T13:14:34Z

@secondsun @matzew Maybe it should be added to http://aerogear.org/docs/guides/aerogear-android/how-to-build-aerogear-android/ that at least an emulator must be running to build.

secondsun · 2014-10-08T13:23:47Z

@sebastienblanc Or you can just build the library without running the tests?
Anyway, updating the docs is on our jira list.

matzew · 2014-10-08T13:45:38Z

why not launch the integration tests on a specific profile, which is not enabled by default?

That's what we did on the server-side as well (arquillan even got moved into its own repo)

secondsun · 2014-10-08T13:47:11Z

@matzew Because that doesn't work. If you can make it work feel free to submit a PR.

matzew · 2014-10-08T13:48:13Z

oh, wow. too bad :)

secondsun · 2014-10-08T13:56:09Z

@matzew So it seems I'm a bit of a liar. The docs on the maven plugin are old and it supports -Dandroid.test.skip=true now. (the docs tell you to use a different flag which doesn't work. Ergo my earlier angst)

secondsun · 2014-10-08T18:04:48Z

I've added a helloWorld branch to the PR description (https://github.com/secondsun/aerogear-push-helloworld/tree/registrations)

danielpassos · 2014-10-09T20:38:06Z

.travis.yml

@@ -15,8 +16,8 @@ env:

 before_install:

-  - echo no | android create avd --force -n test -t $ANDROID_TARGET --abi $ANDROID_ABI
-  - emulator -avd test -no-skin -no-audio -no-window &
+  - echo no | android create avd --force -n test -t 'Google Inc.:Google APIs:19' --abi $ANDROID_ABI 


$ANDROID_TARGET did not work?

It would have a problem with the path to the things later on.
Link to things : https://github.com/secondsun/aerogear-android-push/blob/registrations/.travis.yml#L32

danielpassos · 2014-10-09T21:02:31Z

✔️ Register
✔️ Receive push message

But I was thinking... Is not time to we kill all http duplicated here and delegate that to pipe module? Wdyt?

secondsun · 2014-10-09T22:06:49Z

@danielpassos Done!

danielpassos · 2014-10-10T01:10:36Z

Travis don't like this because we need update support library version. I'm working on update android bom

For more information see: https://travis-ci.org/danielpassos/aerogear-android-push#L1442

danielpassos · 2014-10-10T14:13:16Z

I'd like to update Android bom and pipe to make travis happy before merge it

Update needs to compile pipe module

Android updates aerogear-parent#27

Pipe changes to make travis happy

https://github.com/danielpassos/aerogear-android-pipe/compare/travis-ci

Pipe travis happy

https://travis-ci.org/danielpassos/aerogear-android-pipe

matzew · 2014-10-16T08:24:31Z

@danielpassos agreed on the bom

abstractj · 2014-10-21T12:41:45Z

@danielpassos @secondsun only to avoid my itching merge finger. I will close it until we update and release the bom. Feel free to reopen when we think it's "mergeable"

danielpassos · 2014-11-03T13:16:10Z

Since we are with some travis problem[1] I'm reopening and about to merge it.

@secondsun Could you rebase/update that?

[1] http://aerogear-dev.1069024.n5.nabble.com/aerogear-dev-Travis-problem-with-Android-Lollipop-td9706.html

danielpassos · 2014-11-03T15:44:43Z

Hi @secondsun

Wdyt about remove PushType?
Maybe move AeroGearGCM* for the impl package? Not sure about that

danielpassos · 2014-11-03T16:30:55Z

@qmx Could you review that?

qmx · 2014-11-04T17:58:20Z

@secondsun could you please do a brief git history review? I think those duplicated commit messages can be merged into one, and the cleanup-like ones into a bigger cleanup commit.

danielpassos · 2014-11-04T18:18:54Z

👀

danielpassos · 2014-11-04T18:21:58Z

The code looks good to me but I'd like to test it using aerogear-push-helloworld first.

danielpassos · 2014-11-04T20:15:27Z

The logic of Registrations was moved to RegistrarManager maybe kill Registrations class?

danielpassos · 2014-11-04T20:41:40Z

aerogear-android-push/pom.xml

+            <artifactId>aerogear-android-pipe</artifactId>
+            <version>${aerogear.android.pipe.version}</version>
+            <type>aar</type>
+        </dependency>


Move dependencies to library instead of root pom like we did with the other modules?

In this case it is correct here because the tests use -core for some things.

danielpassos · 2014-11-04T20:46:56Z

We also need to make travis happy. I think travis don't like Google Inc.:Google APIs:19 anymore

danielpassos · 2014-11-04T20:48:10Z

I've tested it using aerogear-push-helloworld and works like a charm.

secondsun · 2014-11-04T21:20:55Z

Per @qmx did a big rebase

qmx · 2014-11-05T00:07:12Z

yay! Will review in a bit :)

qmx · 2014-11-05T02:31:26Z

👍 apply the formatter and ship it :)

abstractj · 2014-11-05T03:28:02Z

@secondsun landed

secondsun force-pushed the registrations branch 2 times, most recently from ab15920 to 67e8562 Compare October 8, 2014 03:02

matzew reviewed Oct 8, 2014
View reviewed changes

danielpassos reviewed Oct 9, 2014
View reviewed changes

abstractj closed this Oct 21, 2014

danielpassos reopened this Nov 3, 2014

secondsun force-pushed the registrations branch from f0eaff4 to 8f0e8d5 Compare November 3, 2014 15:15

danielpassos reviewed Nov 4, 2014
View reviewed changes

secondsun added 3 commits November 4, 2014 16:19

Creating Registrations API classes

c35f6ce

Removing deprecated classes and methods

a126a04

Updating Test classes

c288f1a

secondsun force-pushed the registrations branch from ccdb25e to f61472e Compare November 4, 2014 21:20

secondsun force-pushed the registrations branch from f61472e to ea028a1 Compare November 4, 2014 21:29

secondsun added 5 commits November 4, 2014 16:42

Fixing some travis bugs

8874a3e

Using HttpProvider from pipe

034eba0

Fixing regresstions from merge

f5290d1

Creating gcm package

3a049d9

Disabling javadoc for tests

17d7757

secondsun force-pushed the registrations branch from ea028a1 to 17d7757 Compare November 4, 2014 21:42

Updating Android ABI to use Google

6a9efa3

secondsun force-pushed the registrations branch from 8b67f39 to 6a9efa3 Compare November 4, 2014 22:33

qmx mentioned this pull request Nov 5, 2014

fix wrong indentation for switch/case blocks aerogear-attic/aerogear-misc#6

Merged

abstractj merged commit 6a9efa3 into aerogear:master Nov 5, 2014

Registrations #15

Registrations #15

Conversation

secondsun commented Oct 7, 2014

secondsun commented Oct 7, 2014

matzew commented Oct 8, 2014

secondsun commented Oct 8, 2014

matzew Oct 8, 2014

Choose a reason for hiding this comment

secondsun Oct 8, 2014

Choose a reason for hiding this comment

matzew Oct 8, 2014

Choose a reason for hiding this comment

matzew commented Oct 8, 2014

secondsun commented Oct 8, 2014

sebastienblanc commented Oct 8, 2014

secondsun commented Oct 8, 2014

matzew commented Oct 8, 2014

secondsun commented Oct 8, 2014

matzew commented Oct 8, 2014

secondsun commented Oct 8, 2014

secondsun commented Oct 8, 2014

danielpassos Oct 9, 2014

Choose a reason for hiding this comment

secondsun Oct 10, 2014

Choose a reason for hiding this comment

danielpassos commented Oct 9, 2014

secondsun commented Oct 9, 2014

danielpassos commented Oct 10, 2014

danielpassos commented Oct 10, 2014

matzew commented Oct 16, 2014

abstractj commented Oct 21, 2014

danielpassos commented Nov 3, 2014

danielpassos commented Nov 3, 2014

danielpassos commented Nov 3, 2014

qmx commented Nov 4, 2014

danielpassos commented Nov 4, 2014

danielpassos commented Nov 4, 2014

danielpassos commented Nov 4, 2014

danielpassos Nov 4, 2014

Choose a reason for hiding this comment

secondsun Nov 4, 2014

Choose a reason for hiding this comment

danielpassos commented Nov 4, 2014

danielpassos commented Nov 4, 2014

secondsun commented Nov 4, 2014

qmx commented Nov 5, 2014

qmx commented Nov 5, 2014

abstractj commented Nov 5, 2014