Fix categories config #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@secondsun Could you give it a spin? |
| @@ -245,7 +245,7 @@ public UnifiedPushConfig setAlias(String alias) { | |||
| * | |||
| */ | |||
| public UnifiedPushConfig setCategories(List<String> categories) { | |||
| this.categories = new ArrayList<String>(categories); | |||
| this.categories = categories; | |||
There was a problem hiding this comment.
Why did we need to stop doing a defensive copy?
There was a problem hiding this comment.
Only because it does not work. I asked me the same when community send a bug report. I did some tests and it does not work and I have no idea why :)
There was a problem hiding this comment.
Weird, I just reverted this file and reran the automated tests and it works.
Is there a problem when it is running in the demo or something?
There was a problem hiding this comment.
@secondsun Yes, try use setCategories with Hello World Project and check the categories in UPS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See AGDROID-502