This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sebastienblanc care to take a look? |
👀 too |
👓 |
@sebastienblanc As discussed with @edewit to avoid compilation issue for ios plugin, we need AGPushPlugin.h to be modify to add @Property |
+1 on iOS |
+1 on Android , I will test on Windows tomorrow morning |
PS: @edewit don't forget to put in your PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows android and iOS support, to test add
sendMetricInfo
in json:For testing windows be sure to add the windows page parameter: