Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Cordova Metrics support #69

Merged
merged 11 commits into from Jun 15, 2015
Merged

Cordova Metrics support #69

merged 11 commits into from Jun 15, 2015

Conversation

edewit
Copy link
Member

@edewit edewit commented Jun 2, 2015

Windows android and iOS support, to test add sendMetricInfo in json:

{
            "pushServerURL": "<host url e.g http://server:port/ag-puhs>",
            "sendMetricInfo": true,

For testing windows be sure to add the windows page parameter:

{
     "message": {
      "alert": "Hello metrics",
      "windows": { 
          "page": "cordova" 
       }
     }

@edewit
Copy link
Member Author

edewit commented Jun 2, 2015

@sebastienblanc care to take a look?

@corinnekrych
Copy link
Contributor

👀 too

@sebastienblanc
Copy link
Member

👓

@corinnekrych
Copy link
Contributor

@sebastienblanc As discussed with @edewit to avoid compilation issue for ios plugin, we need AGPushPlugin.h to be modify to add @Property

@corinnekrych
Copy link
Contributor

+1 on iOS
I've used HelloWorld app tpo test it, i only had to change the push-config.json to included:
"sendMetricInfo": true,
Tested for background and newly launched app. Both cases send metrics ok.

@sebastienblanc
Copy link
Member

+1 on Android , I will test on Windows tomorrow morning

@corinnekrych
Copy link
Contributor

PS: @edewit don't forget to put in your PR AGPushPlugin.h modified with chanelId property.

edewit added a commit that referenced this pull request Jun 15, 2015
Cordova Metrics support
@edewit edewit merged commit b05a1e5 into aerogear:master Jun 15, 2015
@edewit edewit deleted the metrics branch July 17, 2015 08:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants