Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGDIGGER-57 - fetch artifacts support #3

Merged
merged 2 commits into from
Dec 12, 2016

Conversation

wtrocki
Copy link
Contributor

@wtrocki wtrocki commented Dec 9, 2016

Motivation

Allow to fetch build artifacts artifacts

Review @aliok @luigizuccarelli @matzew

@matzew
Copy link
Contributor

matzew commented Dec 12, 2016

👍

@aliok
Copy link
Member

aliok commented Dec 12, 2016

should we have some unit tests?
we have some stuff on Java client.
@wtrocki @matzew WDYT?

digkins login <url> [user] [password]

Stream jenkins logs for triggered build
digkins log <job> <queueid>

Get job artifacts for specified build
artifact <job> <buildNumber>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

digkins artifact <job> bla

@wtrocki
Copy link
Contributor Author

wtrocki commented Dec 12, 2016

@aliok
We can write some basic unit tests to cover all commands - not just this one.
Let's sync on that to figure out what testing framework we should use. I do not have any preference - we can use Mocha etc.

@aliok
Copy link
Member

aliok commented Dec 12, 2016

@wtrocki I personally like these:

  • Mocha
  • Chai (+Chai strings, Chai promise etc.)
  • Mockery OR Sinon

@aliok
Copy link
Member

aliok commented Dec 12, 2016

I think we can merge this one.
Maybe write unit tests in a separate PR? It is up to you.
You introduce the tests.

@wtrocki
Copy link
Contributor Author

wtrocki commented Dec 12, 2016

@aliok Have you verified this? Is solution ok for you. Going to create new ticket to cover basic test base.

@aliok
Copy link
Member

aliok commented Dec 12, 2016

@wtrocki Yes I have verified it locally. It is perfect: how it should be!

@wtrocki wtrocki merged commit 341fdb5 into aerogear:master Dec 12, 2016
@wtrocki wtrocki deleted the AGDIGGER-57 branch December 12, 2016 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants