Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agios 522.swift2.3 #100

Merged
merged 12 commits into from Oct 14, 2016
Merged

Conversation

corinnekrych
Copy link
Contributor

@jcesarmobile mind a review?
For Howdy watch app, I've kept the framework approach (to be changed in favor of CocoaPods eventually), i've rebuilt the latest version of the library.
wdyt?

@jcesarmobile
Copy link
Contributor

👀

@jcesarmobile
Copy link
Contributor

The README.mds or the apps only mention we use Swift without specifying a version, I think we should mention that it's 2.3
Howdy has the deployment target set to iOS 10, but README.md says it supports iOS 9, and it works on iOS 9 (I tested), should be changed to iOS 9.
Root README.md says "Recipe app build with Xcode7.3", I think it should be "Recipe apps built with Xcode8"

@jcesarmobile
Copy link
Contributor

corinnekrych#9

Updated README.mds to specify the Swift version
@jcesarmobile
Copy link
Contributor

LGTM

@corinnekrych corinnekrych merged commit d42bec0 into aerogear:master Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants