Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agios 146.revoke.token #17

Merged
merged 4 commits into from May 19, 2014

Conversation

corinnekrych
Copy link
Contributor

No description provided.


To revoke access:

[_restAuthzModule reqvokeAccessSuccess:^(id object) { [10]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/reqvokeAccessSuccess/revokeAccessSuccess

@cvasilak
Copy link
Contributor

tested and worked great 👍

small comment on the flow:
not sure, I think when opening the app we can continue display the alert for the "first time" grant. Upon grant the 'Revoke' button should appear. When successfully revoked, we should clear out the table list from the old data and remove the 'Revoke Button' from UI. Clicking "Refresh" button still asks for "Grant" so I think grant button is not needed.

wdyth?

@corinnekrych
Copy link
Contributor Author

@cvasilak Right, dialog popup ease the flow. Mainly done as you described (just one detail different). Instead of removing "Revoke" I disabled it. A better UX stuff to keep the buttons present but enable/disable them when needed.
Ok for you?

@cvasilak
Copy link
Contributor

+1 for "disabling", I think I like it better that way.

tested and worked great 👍

@corinnekrych corinnekrych merged commit 7536b71 into aerogear:master May 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants