Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agios 237 #29

Merged
merged 16 commits into from Sep 16, 2014
Merged

Agios 237 #29

merged 16 commits into from Sep 16, 2014

Conversation

corinnekrych
Copy link
Contributor

This PR is an initial OAuth2 example (Shoot) which does OAuth2 authz with GoogleDrive and Facebook.
It does not do the actual upload as we're missing AGIOS-229, but @cvasilak you've got all the ground to test multipart upload with this initial version.

To test on Google no configuration required. To test on Facebook some configuration is required as fb required client_secret we can't commit config sample.

@corinnekrych
Copy link
Contributor Author

@cvasilak @danbev do you mind reviewing it?

@danbev
Copy link
Contributor

danbev commented Sep 8, 2014

@corinnekrych absolutely

@corinnekrych
Copy link
Contributor Author

@cvasilak please rebase as I've just added new http, oauth2 modules + shoot demo with acount manager for AGIOS-253

As we're working on closely related subjets, this branch is a WIP, waiting for @cvasilak to propose PRs. cc @danbev it may be wise to wait a bit for the review.

@danbev
Copy link
Contributor

danbev commented Sep 16, 2014

Tested Shoot and it works like a charm!
👍 On merging after the above comments have been addressed (the import one being option as @corinnekrych told be these will be used in the near future when Cocoapods are available for Swift)

@cvasilak
Copy link
Contributor

👍 to merge, per discussion am in the process of creating separate Jiras for my comments so that we don't overcommit this PR

@corinnekrych corinnekrych merged commit a35e643 into aerogear:swift Sep 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants