Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PipeDemo #3

Merged
merged 9 commits into from Jan 21, 2014
Merged

PipeDemo #3

merged 9 commits into from Jan 21, 2014

Conversation

cvasilak
Copy link
Contributor

done for AGIOS-132

@cvasilak cvasilak mentioned this pull request Jan 16, 2014
Merged
@corinnekrych
Copy link
Contributor

I like asynch queue for images.
would it be possible to align text either truncating images or adding padding?
What about choosing another name for the app. Instead of PipeDemo something like Buddies, AeroGearCommitter?

corinnekrych
corinnekrych reviewed Jan 17, 2014
View reviewed changes
PipeDemo/PipeDemo/PipeDemo-Prefix.pch
@@ -0,0 +1,16 @@
//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AG header needed

@cvasilak
Copy link
Contributor Author

project renamed :)

@matzew
Copy link
Contributor

matzew commented Jan 17, 2014

👍

2 similar comments
@corinnekrych
Copy link
Contributor

+1

@danielpassos
Copy link
Collaborator

👍

@cvasilak cvasilak merged commit 460d42b into aerogear:master Jan 21, 2014
corinnekrych pushed a commit that referenced this pull request Nov 3, 2016
@jcesarmobile
Merge pull request #3 from corinnekrych/RHMAP-10113.review
6b99500 
Drop some prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@cvasilak @corinnekrych @matzew @danielpassos