Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shoot is Swift2.3 #96

Merged
merged 3 commits into from Sep 22, 2016
Merged

Shoot is Swift2.3 #96

merged 3 commits into from Sep 22, 2016

Conversation

corinnekrych
Copy link
Contributor

Migrate to Swift2.3 (using Xcode8 migrator)
Project can be opened in Xcode 7.3.1 or Xcode8 and ran on iOS10

@danielpassos
Copy link
Collaborator

Feature Status
XCode 7.3 ✔️
XCode 8.0 Waiting for download
iOS 10 Installing

@danielpassos
Copy link
Collaborator

XCode 8.0

When open

screenshot 2016-09-21 18 56 35
I have clicked in later

screenshot 2016-09-21 18 56 05
I have clicked in later

When try to build

“Use Legacy Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.

After convert to Swift 3

screenshot 2016-09-21 19 01 31

screenshot 2016-09-21 19 02 58

@corinnekrych Convert screens are something expected?

@corinnekrych
Copy link
Contributor Author

corinnekrych commented Sep 22, 2016

@danielpassos Good catch I forgot to check-in the CocoaPoads workaround in Podfile.

The issue is located in the generated Pods for the aerogear-ios-http/oauth2, see:
unspecified-9
This is a known issue with CocoaPods 1.0.1 (it is fixed in 1.1.0.beta.1).
With the addition in Podfile, you will not be prompted again.
🌹 Could you give it another trial?
Thanks!

@jcesarmobile
Copy link
Contributor

Builds and works fine on both Xcode 7.3.1 and Xcode 8 now

Copy link
Collaborator

@danielpassos danielpassos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@danielpassos danielpassos merged commit 50352f8 into aerogear:master Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants