Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseURL support, delegates and further polish #12

Merged
merged 4 commits into from Oct 16, 2014

Conversation

cvasilak
Copy link
Contributor

this PR contains:

  • added upload/download support by introducing delegates AGIOS-233
  • 'Http' refactored to support baseURL. Now if instantiated with one, http methods will accommodate to use if a baseURL is present AGIOS-265
  • polish on the serialisers by splitting to HttpRequestSerializer and JSONRequestSerializer.
  • Http tests refactored to go against a real service instead of stub (using httpbin.org). Added tests that exercise all http methods together with upload/download. (Note it can be refactored to use stubs in the future but I wanted to make they work as advertised against a real 'web' service' in our initial release)

The lib changes here are included in the Shoot cookbook PR
aerogear/aerogear-ios-cookbook#38

(I am sorry for incorporating two fixes in one PR, but delegates and baseURL were somewhat interrelated so I opted to work simultaneously on them)

@corinnekrych
Copy link
Contributor

+1 let's merge

@corinnekrych corinnekrych merged commit 7eafa7c into aerogear:master Oct 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants