New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added basic/digest support option #17
Conversation
|
||
import XCTest | ||
import AeroGearHttp | ||
import AGURLSessionStubs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we don't stub http request we can remove this import
update readme with:
+1 to merge apart from small comments |
0f7c6c6
to
33da77c
Compare
@corinnekrych have updated based on your feedback |
For the test i'd add more test with httpstub instead of having all test "integration" like going to httpbin.org +1 to merge |
thank you @corinnekrych have updated |
On it.... |
@cvasilak I'm looking at the sources, due to my poor skills on swift lemme ask. Is HTTPS enforced? Not a deal breaker to merge this PR, but I would like to know before. |
@corinnekrych I can PR that, but I think we should provide examples with HTTPS by default. Let me know where can I help. |
@abstractj thank you for your feedback not enforced the user can use either HTTP/HTTPS when constructing the request. For that reason have added an advisory in the javadoc for each function that HTTPS is preferred if credential is passed, and have updated auth tests to use thanks again |
+1 for extra readme info |
done for AGIOS-255
the functionality is exercised in the
HttpAuthenticationTests
test case class where the different http/digest options are executed plus a test case with where a protection space is used and assigned to the NSURLSession.defaultConfiguration() (without the need to pass any credential object)besides the tests, a demo app exerting basic/digest has also been created to demonstrate and can be found here