Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added basic/digest support option #17

Merged
merged 10 commits into from Dec 10, 2014
Merged

Conversation

cvasilak
Copy link
Contributor

done for AGIOS-255

the functionality is exercised in the HttpAuthenticationTests test case class where the different http/digest options are executed plus a test case with where a protection space is used and assigned to the NSURLSession.defaultConfiguration() (without the need to pass any credential object)

besides the tests, a demo app exerting basic/digest has also been created to demonstrate and can be found here


import XCTest
import AeroGearHttp
import AGURLSessionStubs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we don't stub http request we can remove this import

@corinnekrych
Copy link
Contributor

update readme with:

+1 to merge apart from small comments

@cvasilak cvasilak force-pushed the AGIOS-255 branch 3 times, most recently from 0f7c6c6 to 33da77c Compare December 2, 2014 15:54
@cvasilak
Copy link
Contributor Author

cvasilak commented Dec 2, 2014

@corinnekrych have updated based on your feedback

@corinnekrych
Copy link
Contributor

For the test i'd add more test with httpstub instead of having all test "integration" like going to httpbin.org
But we can do that in separate PR.

+1 to merge

@cvasilak
Copy link
Contributor Author

cvasilak commented Dec 4, 2014

thank you @corinnekrych have updated

@abstractj
Copy link

On it....

@abstractj
Copy link

@cvasilak I'm looking at the sources, due to my poor skills on swift lemme ask. Is HTTPS enforced?

Not a deal breaker to merge this PR, but I would like to know before.

@abstractj
Copy link

@corinnekrych I can PR that, but I think we should provide examples with HTTPS by default.

Let me know where can I help.

@cvasilak
Copy link
Contributor Author

cvasilak commented Dec 9, 2014

@abstractj thank you for your feedback

not enforced the user can use either HTTP/HTTPS when constructing the request. For that reason have added an advisory in the javadoc for each function that HTTPS is preferred if credential is passed, and have updated auth tests to use HTTPS by default for that reason.

thanks again

@corinnekrych
Copy link
Contributor

+1 for extra readme info

@cvasilak cvasilak merged commit 8dd3170 into aerogear:master Dec 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants