Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agios 325 #22

Merged
merged 2 commits into from Dec 22, 2014
Merged

Agios 325 #22

merged 2 commits into from Dec 22, 2014

Conversation

corinnekrych
Copy link
Contributor

  • Replace invalidateAndCancel by finishTasksAndInvalidate to trigger releasing of resources after task completed
  • add one unit test
  • I also notices JSONRequestSerializer for an empty file in commit history, so put back its initial content + addintional test for releasing

@cvasilak do you mind reviewing?

@corinnekrych
Copy link
Contributor Author

@cvasilak similar discussing were going on on alamofire fwk: Alamofire/Alamofire#269 (comment)

Shall we also remove the deinit and leave it to the developer to call it when needed. deinit is not the right place.

@abstractj abstractj merged commit b988e6d into aerogear:master Dec 22, 2014
@abstractj
Copy link

@corinnekrych landed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@corinnekrych @abstractj