Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert AeroGearHttp Test scheme to Integration Tests scheme #29

Closed
wants to merge 5 commits into from

Conversation

cvasilak
Copy link
Contributor

this PR adds an 'IntegrationTests' target that enables tests to be run within the context of the emulator. Details of why this was required can be found on our JIRA AGIOS-330

To test:
After running pod install and opening the workspace, choose IntegrationTest schema, and then choose Product->Test. Tests should run and succeed.

@corinnekrych @danbev mind to have a look?

@corinnekrych
Copy link
Contributor

@cvasilak Rather than making all tests integration tests, i think we should have most of them in unit tests using httpstub to mock http layer(like we used to). I've created a JIRA for that:
AGIOS-328
Also be caution about AeroGearHttp.xcodeproj/project.pbxproj going xml format makes it difficult to track changes.

@cvasilak
Copy link
Contributor Author

@corinnekrych +9001 that's exactly the reason as you stated, so we are now free to separate our tests:

a) Unit Tests (with httpstub mock) go to the default AeroGearHttp test target and
b) integrations tests (that this PR is) go to IntegrationTests target and since the tests are really integration tests and require a running emulator for some services to be available plus network access. Unless you mean getting rid of the existing tests and going only with unit tests with mocking which I am -1 tbh

I think that is clean and visible separation, wdyt?

@corinnekrych
Copy link
Contributor

@cvasilak most of those tests could/should be unit tests. AGIOS-328 purpose is to bring them back to unit tests. So I'm -1 migrating them to int. tests because then we have only integration tests and no unit tests.
Let's move them to unit tests, then we can add one test suite for integrstion test. Unit tests are the base of pyramid.
I'd rather close the PR for now and revisit once we've got most of the test unit tests.

@danbev
Copy link
Contributor

danbev commented Jan 12, 2015

@cvasilak @corinnekrych Should I still do a review or hold off?

@cvasilak
Copy link
Contributor Author

thank you @danbev!

mind to hold off for a bit, we will have a discussion with @corinnekrych about it and will update this PR accordingly.

@cvasilak
Copy link
Contributor Author

as discussed closing this PR.

a way to introduce unit tests with mocks plus coexisting with the integration test target schema that this PR introduces would be possible different and would be discussed on the ML.

@cvasilak cvasilak closed this Jan 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants