Agios 414.webview #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👀 looking at |
|
|
||
| import UIKit | ||
|
|
||
| class WebViewController: UIViewController, UIWebViewDelegate { |
There was a problem hiding this comment.
possible rename class to OAuthWebViewController so it is easier identifiable?
There was a problem hiding this comment.
can we embed the oauth controller inside a navigation controller with a close button on the left to dismiss if the user decides to?
|
@corinnekrych @cvasilak is this ready? |
|
I've rename and fix rotating issue as suggested. I think we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cvasilak mind to review?
This PR add the option to do authz request with a webview.
To test it see aerogear/aerogear-ios-cookbook#78