This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Added notifications for success/failure for offline operations #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtrocki
reviewed
Jan 31, 2019
|
@jhellar Do you mind mentioning this new api in docs as well? |
|
Reminder to myself to add this option to ionic showcase app (for verification) |
wtrocki
reviewed
Jan 31, 2019
| @@ -121,10 +120,16 @@ export class OfflineQueueLink extends ApolloLink { | |||
| return new Promise((resolve, reject) => { | |||
| opEntry.subscription = forward(operation).subscribe({ | |||
| next: result => { | |||
| if (this.listener && this.listener.onOperationSuccess) { | |||
There was a problem hiding this comment.
[Oftopic] Optional chaining in typescript will transpile that. More info https://medium.com/inside-rimeto/optional-chaining-in-typescript-622c3121f99b
|
@wtrocki thanks for review, I've added description to readme |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://issues.jboss.org/browse/AEROGEAR-8345