Skip to content
This repository has been archived by the owner on Oct 14, 2020. It is now read-only.

upgrade keycloak to 1.0.2 #28

Merged
merged 1 commit into from Oct 16, 2014
Merged

Conversation

lfryc
Copy link
Contributor

@lfryc lfryc commented Oct 16, 2014

tested with master of unifiedpush-server, login/logout/account management works as expected

@matzew
Copy link
Contributor

matzew commented Oct 16, 2014

+1 did same tests, but you beat me in submitting a PR :)

@matzew
Copy link
Contributor

matzew commented Oct 16, 2014

Let's wait a bit before merging this: http://lists.jboss.org/pipermail/aerogear-dev/2014-October/009368.html

@danielpassos
Copy link
Collaborator

What about add it in 0.2.8? I did not press the button yet.

@danielpassos danielpassos merged commit eb6b337 into aerogear:master Oct 16, 2014
@danielpassos
Copy link
Collaborator

I'm including it on 0.2.8 release

@abstractj
Copy link
Contributor

@matzew
Copy link
Contributor

matzew commented Oct 16, 2014

@abstractj see here:
aerogear/aerogear-unifiedpush-server#401

once the parent, containing 1.0.2 KC reference is released, on UPS a new PR similar to aerogear/aerogear-unifiedpush-server#401 should be issued, using the latest parent version.

In the past we agreed on doing the override on the UPS, instead of consuming KC from parent, since we had a lot of KC releases.

Since that now has settled, IMO it's time to go back to the parent based model, where we consume the KC version from, similar to other libraries defined in the parent pom.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants