Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Added build workflow #8

Merged
merged 2 commits into from
Jun 8, 2020
Merged

Added build workflow #8

merged 2 commits into from
Jun 8, 2020

Conversation

ziccardi
Copy link
Member

@ziccardi ziccardi commented May 14, 2020

Motivation

We wanted a workflow that could validate the code before merging it

What

A new workflow has been created with 2 jobs:

  • android-build
    • checkout the repo
    • installs node
    • installs the js deps
    • compile the android target
  • ios-build
    • checkout the repo
    • installs node
    • installs the js deps
    • installs pods for the ios target
    • create a simulator
    • compile the ios target

@ziccardi ziccardi force-pushed the BUILD-WORKFLOW-OPTIMIZED branch 2 times, most recently from 60d6e45 to cd22c56 Compare May 14, 2020 09:47
The workflow has been renamed to build because it now handles both ios and android
A new job for building android has been added
Copy link
Contributor

@secondsun secondsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It';s been 3 weeks, let's merge it and see what breaks

@secondsun secondsun merged commit 9ae8ec6 into master Jun 8, 2020
@secondsun secondsun deleted the BUILD-WORKFLOW-OPTIMIZED branch June 8, 2020 13:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants