E2E test template #1
Conversation
wojta
commented
Mar 7, 2018
•
wojta
commented
- proof it runs on some initial test
- add login test
- add logout test
There was a problem hiding this comment.
Other than the comments I have made this code looks good to me.
However the test has failed due to missing file which is in mentioned in .gitignore:
/home/thnolan/feedhenry/aerogear-sdk-e2e-tests/local.properties
Details of how to create this file and example file need to be placed in README.md
| /** | ||
| * Chrome intro screen that pops up on Android. | ||
| */ | ||
| interface ChromeIntroScreen : PageObject { |
There was a problem hiding this comment.
It is possible to set the chromeOptions when starting a test and disable things such as the welcome page, setting chrome as default pop up, cert errors etc. This would be much more preferable than trying to create our own classes to control the logic required to handle all of the possible problems.
https://github.com/twnolan/appium-experimentation/blob/master/test/login-logout.spec.js#L20 - this is how to disable some of these in javascript
https://appium.io/docs/en/writing-running-appium/caps/ - this has all the information on desired capabilities for appium, and some information on android and ios only capabilities regarding chrome and safari options
There was a problem hiding this comment.
thanks, I wasn't aware of that.
| $ ./gradlew test | ||
| ``` | ||
|
|
There was a problem hiding this comment.
There should also be a section on an example of creating a test, or link to the library documentation for making a test as this is a non-standard library.
There was a problem hiding this comment.
yes, that's right. It should be.
|
finalized changes @twnolan, please approve if it's ok |
|
sorry, forgot that local.properties |
