Supply settings to constructor #11
Conversation
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "url": "http://localhost:8080/ag-push", | |||
| "applicationID": "aa3cfaad-8cd4-4b3c-af23-08417b879d00", | |||
There was a problem hiding this comment.
shit, this should be applicationId, let me change this
|
@lholmquist overall looks good +1 fearlessquist |
|
welp, thats good enough for me :) |
|
@lholmquist how about a little hint on the README ? |
@lholmquist yeah, instead of inlining, I thought about actually passing in something like |
|
@lholmquist any thoughts about showing how to pass in a file, like |
|
@matzew i thought about it, but i think this is sort of common knowledge for people familar with doing stuff in node |
|
even I know :) |
|
ok, if we don't want to show it that's fine. I'd have to google in case I was forced to use node. But that's ok On Tue, Nov 4, 2014 at 2:15 PM, Lucas Holmquist notifications@github.com
Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ |
|
I would also have to google for that, I think an example can not hurt. |
|
it's in the example already :) https://github.com/aerogear/aerogear-unifiedpush-nodejs-client/blob/master/example.js#L7 |
|
still not sure why it's impossible to describe that on the README. In case the aerogear homepage has that already, than fine On Tue, Nov 4, 2014 at 2:45 PM, Lucas Holmquist notifications@github.com
Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ |
|
@matzew not impossible just very strange |
|
ok, looks like no need for it :) On Tue, Nov 4, 2014 at 3:13 PM, Erik Jan de Wit notifications@github.com
Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ |
A slight change to the node.js sender.
You now supply the settings: url, applicationId, and masterSecret in the constructor.
which makes the "options" for the
sendoptional