Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ability to provide custom headers AGJS-300 #22

Merged
merged 1 commit into from
Sep 3, 2015
Merged

ability to provide custom headers AGJS-300 #22

merged 1 commit into from
Sep 3, 2015

Conversation

lfryc
Copy link
Contributor

@lfryc lfryc commented Sep 3, 2015

@lfryc
Copy link
Contributor Author

lfryc commented Sep 3, 2015

@lholmquist I still have to test it - hmm reminds me that I should provide some tests :-)

@lfryc
Copy link
Contributor Author

lfryc commented Sep 3, 2015

but be my guest if you want to review it yet, hehe

@lholmquist
Copy link
Member

i'll be waiting patiently for those tests :)

also, can you add the options to the readme and the js-doc comments :)

@lfryc
Copy link
Contributor Author

lfryc commented Sep 3, 2015

@lholmquist sure thing, updates to come

@lfryc
Copy link
Contributor Author

lfryc commented Sep 3, 2015

@lholmquist done, 👀 🌈 🐱 ?

@lholmquist
Copy link
Member

@lfryc looks good, i'll merge then cut a release, 0.9.0

@lholmquist lholmquist merged commit 61e0d8f into aerogear:master Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lfryc @lholmquist