This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Multiple categories #106
Merged
Multiple categories #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matzew
commented
Nov 4, 2013
matzew
commented
- Allowing devices/clients to be registered in multiple categories (API change on registration endpoint)
- Supporting multiple categories on SEND (API change on send endpoint)
- Adding unit test for DAO and Installation entity
…the direct category usage
|
|
||
| /** | ||
| * Used for (SimplePush) Sender API. Queries the available SimplePush "pushEndpoint URLs"(device-type : web) for a given variant, based on provided criteria | ||
| */ | ||
| List<String> findAllSimplePushEndpointURLsForVariantIDByCriteria(String variantID, String category, List<String> aliases); | ||
| List<String> findAllSimplePushEndpointURLsForVariantIDByCriteria(String variantID, List<String> categorie, List<String> aliases); |
I don't see any comment but I see that was fixed, as was my other comment. |
| @@ -6,7 +6,7 @@ | |||
| * you may not use this file except in compliance with the License. | |||
| * You may obtain a copy of the License at | |||
| * | |||
| * http://www.apache.org/licenses/LICENSE-2.0 | |||
| * http://www.apache.org/licenses/LICENSE-2.0 | |||
There was a problem hiding this comment.
are the extra 2 spaces intentional ?
There was a problem hiding this comment.
will run formating AFTER this :-)
|
👍 and cool to have some DAO unit tests ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.