This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Restructures the Client,Variant & Server_Sdk files for a cleaner sidebar #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziccardi
suggested changes
Feb 28, 2020
There was a problem hiding this comment.
The links to the images don't work anymore (they are using relative path, so many of them should be changed from './assets/....' to '../assets/....'.
I added some comments about the dept of the headers: since we removed the main header, they all can be raised one or two levels (depending on the case).
I would also remove all the 'Using', 'Creating' and 'Configuring' from the sidebar titles since they are redundant.
ziccardi
suggested changes
Feb 28, 2020
ziccardi
approved these changes
Feb 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://issues.redhat.com/browse/AEROGEAR-10167
What
This PR splits up the configuring_clients.md, configuring_variants.md and the server_sdk.md file.
This was done so that each option would be on its own markdown file and could be added to the side bar for an easier navigation experience when using the website.