UUID generation change

[matzew]

• Moving PD and pushApp/variantID (UUID) generation into the model/entity classes;
• getting rid of hibernate annotations
• cleaning up code and tests
• added new test to test PK/ID generation

Was done for:

• AGPUSH-382
• AGPUSH-440

[sebastienblanc]

Since we move all UUID generation into the model, what about the reset https://github.com/aerogear/aerogear-unifiedpush-server/blob/UUID_Generation/src/main/java/org/jboss/aerogear/unifiedpush/rest/registry/applications/AbstractVariantEndpoint.java#L64 ?
The model could have a resetSecret() method but I don't know what's the opinion of everyone of putting this kind of logic in a model class.

[kpiwko]

Can we keep setters? They are handy/needed for testing.

[matzew]

@kpiwko done

[matzew]

@sebastienblanc not sure; the set(Master)Secret() would be still there

[edewit]

You could move initialisation to the field:
private String id = UUID.randomUUID().toString();

[kpiwko]

Premature optimization is evil - but could not resist here ;-)

UUID.randomUUID() is quite expensive operation, wouldn't it be possible to skip generation for entity creation when field is actually retrieved from DB? Same holds for other UUID generations.

[edewit]

@kpiwko the id is generated when the class is loaded, putting it in the getter will delay the generation by milliseconds / maybe less.

[kpiwko]

the point was to generate only if null - so generation would not happen if id is retrieved from database. Current impl wil generate UUID and then replace it with value stored in database. See https://issues.jboss.org/browse/AGPUSH-444

[edewit]

your right that is waste of cpu power we could change it, but then we would have to tell jpa to use the getter instead of the field, like this:

    private String id = null;

    @Id
    public String getId() {
        if (id == null) {
          id = UUID.randomUUID().toString();
        }
        return this.id;
    }

but then I get an error in the test MappingException: Could not determine type for: java.util.Set, at table: AbstractVariant, for columns: [org.hibernate.mapping.Column(installations)]

So let's leave that as an issue for possible improvement

[edewit]

oops wrong button