This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Add GCM for Chrome support. AGPUSH-244 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is the guide i followed when creating a testing app |
| /** | ||
| * The type identifier for our Chrome Packaged App variants. | ||
| */ | ||
| CHROME_PACKAGED_APP("chromePackagedApp"); |
There was a problem hiding this comment.
we could, but technically, it isn't for chrome the browser, just the packaged apps
There was a problem hiding this comment.
Ah, thanks
On Thursday, November 14, 2013, Lucas Holmquist wrote:
In src/main/java/org/jboss/aerogear/unifiedpush/api/VariantType.java:
@@ -34,7 +34,12 @@
/**
* The type identifier for our SimplePush variants.
*/
- SIMPLE_PUSH("simplePush");
- SIMPLE_PUSH("simplePush"),
- /**
\* The type identifier for our Chrome Packaged App variants.*/- CHROME_PACKAGED_APP("chromePackagedApp");
we could, but technically, it isn't for chrome the browser, just the
packaged apps—
Reply to this email directly or view it on GitHubhttps://github.com//pull/111/files#r7669187
.
Sent from Gmail Mobile
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that i had the majority of this done. It just needed to be rebased with all those changes that happened
I know we are code freezing tomorrow, so this is more of a review PR until after the release
I have a branch of the Admin UI which i will also send a PR for