This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
fix: 馃悰 webpush messages were not UTF-8 encoded #1127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Webpush messages was encoded using the default encoding, thus generating
errors when sending UTF-8 texts
ISSUE AEROGEAR-10376
What
Changed encoding for webpush messages to UTF-8
Verification Steps
NOTE The cookbook variant contains a bug in the registration. If instead of seeing the message in the web application you see a popup with the message object, reload the page and register again