Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

fix: 馃悰 webpush messages were not UTF-8 encoded #1127

Merged
merged 1 commit into from Jan 13, 2021
Merged

Conversation

ziccardi
Copy link
Member

@ziccardi ziccardi commented Jan 8, 2021

Motivation

Webpush messages was encoded using the default encoding, thus generating
errors when sending UTF-8 texts

ISSUE AEROGEAR-10376

What

Changed encoding for webpush messages to UTF-8

Verification Steps

  1. Use the ups admin console to create a webpush variant for an application. Alternatively the UPS-CLI can be used (see here)
  2. Configure your application to be notified using the created variant (the cookbook app could be used too)
  3. Send a message containing UTF-8 character to the application using the UPS admin ui. (for example "臒眉艧莽")
  4. Check that the message is correctly displayed (with the previous version this was resulting to a series of question marks)

NOTE The cookbook variant contains a bug in the registration. If instead of seeing the message in the web application you see a popup with the message object, reload the page and register again

Webpush messages was encoded using the default encoding, thus generating
errors when sending UTF-8 texts
Copy link
Contributor

@secondsun secondsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@secondsun secondsun merged commit e804a4a into master Jan 13, 2021
@secondsun secondsun deleted the WEBPUSH-UTF8 branch January 13, 2021 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants