SimplePush: use pushEndpoint URL as device token #290
Conversation
…d of having it its own field. We also no longer store channelID, was device-token in the past
Test: Using this as a quick, hacky client: Used the returned pushEndpoint as devicetoken, and did a CURL registration, like:
Now, with the deployed fix, I was able to get the 'onmessage' callback receiving an update, based on a push out of the AdminUI |
@@ -67,7 +66,7 @@ public String getDeviceToken() { | |||
* <ul> | |||
* <li> APNs: <code>deviceToken</code> | |||
* <li> GCM: <code>registrationId</code> | |||
* <li> SimplePush: <code>channelId</code> | |||
* <li> SimplePush: <code>pushEndoint</code> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo "pushEndpoint"
Ok tested with success with Firefox OS 👍 |
For those interested testing it with FFOS, I updated my ChcukPush repo to support this change :) https://github.com/sebastienblanc/chuckpush/ |
I just noticed that I can not toggle an "installation" to "off", I'm getting this error http://pastie.org/9378086 |
Could it be that it's an old database? |
@sebastienblanc @edewit not related to this PR. I am getting the same on MASTER branch (tested with a CLEAN AS7 and CLEAN DB).
|
is that something related to the model simplification ? |
File new JIRA: https://issues.jboss.org/browse/AGPUSH-803 |
landed |
For SimplePush we now use the pushEndpoint URL as device-token instead of having it its own field. We also no longer store channelID, was device-token in the past
Done for https://issues.jboss.org/browse/AGPUSH-532