This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
use PUT method for updating iOS variant when certificate specified #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 tested and could upload a different certificate |
|
tested if only name/description was changed, PATCH is invoked otherwise if certificate is added PUT is invoked. 👍 |
|
@lholmquist could you give this a try as well ? |
|
sure thing |
|
👍 it's good |
|
@lfryc mind rebasing on the latest, and i'll merge |
|
@lholmquist Lukas is out, are you OK I do cherry-pick of this and merge it ? |
|
@matzew oh right, yea, i'll do the merge and such |
|
🚀 in b14f7ec |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/AGPUSH-944