Windows support #370
Windows support #370
Conversation
| * Pattern for windows is a uri that can be 1024 characters long | ||
| * @see <a href="http://blogs.windows.com/windows_phone/b/wpdev/archive/2013/10/22/recommended-practices-for-using-microsoft-push-notification-service-mpns.aspx?Redirected=true">Windows developer blog</a> | ||
| */ | ||
| private static final Pattern WINDOWS_DEVICE_TOKEN = Pattern.compile("http://(.*){0,1024}"); |
There was a problem hiding this comment.
https not supported by them ?
There was a problem hiding this comment.
Your're right that is an error
|
@lfryc want to test it? |
|
Sure, I'm on it... would you mind to rebase it on top of |
… and package json
…ble with double click
|
rebased... |
|
Hmm I believe you have mixed the commits during rebase. Look into the log how many commits are there. |
fixed c-sharp example
|
@lfryc there is no cordova support yet, finishing up the UnifiedPush API now after that hello world quickstart then cordova |
|
@lfryc shall I make a new PR? Because no clue what you mean with mixed the commits? |
|
I think he means that this PR contains 190 commits On Monday, September 1, 2014, Erik Jan de Wit notifications@github.com
Sent from Gmail Mobile |
|
@matzew isn't that what a rebase does? |
|
@edewit rebase should put the commits you want to integrate on top of a target branch ( |
|
Let's open a new PR if that is easier. |
|
not really, @edewit. I'd expect to see only relevant commits and maybe I think I'd do a cherry-pick of the relevant commits, on to a new branch I think you may need to fix some conflicts as well On Monday, September 1, 2014, Erik Jan de Wit notifications@github.com
Sent from Gmail Mobile |
Initial version only supports Toast messages