Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

refactored logout-after-inactivity feature #425

Conversation

lfryc
Copy link
Contributor

@lfryc lfryc commented Nov 4, 2014

  • refresh keycloak token periodically
  • leverage ng-idle and ng-animate
  • upgrades AngularJS to 1.2.26

https://issues.jboss.org/browse/AGPUSH-1025

merge to 1.0.x and master

@lfryc
Copy link
Contributor Author

lfryc commented Nov 5, 2014

@edewit @sebastienblanc hey guys, would you mind to review? 👀

@edewit
Copy link
Member

edewit commented Nov 6, 2014

👀

@edewit
Copy link
Member

edewit commented Nov 6, 2014

I don't get the warning anymore

@lfryc
Copy link
Contributor Author

lfryc commented Nov 6, 2014

Not at all? Interesting -

Btw you can use these settings for debugging this stuff (make timeout lower, enable debug log):
https://github.com/lfryc/aerogear-unifiedpush-server/blob/AGPUSH-1025-refactored-logout-after-inactive/admin-ui/app/scripts/app.js#L52

@edewit
Copy link
Member

edewit commented Nov 7, 2014

@lfryc don't know what I'm doing wrong, but when I run a grunt server I get the following error in the browser:

Module 'ngAnimate' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument.

Did you forget a dependency, or am I doing something wrong?

@edewit
Copy link
Member

edewit commented Nov 7, 2014

Right, so I think you are missing ng-idle and angular-animate in bower.json

@lfryc
Copy link
Contributor Author

lfryc commented Nov 7, 2014

Ah, yes, good catch, adding missing deps!

On Fri, Nov 7, 2014 at 9:15 AM, Erik Jan de Wit notifications@github.com
wrote:

Right, so I think you are missing ng-idle and angular-animate in bower.json


Reply to this email directly or view it on GitHub
#425 (comment)
.

@lfryc lfryc force-pushed the AGPUSH-1025-refactored-logout-after-inactive branch from 38a2766 to 1d0edf1 Compare November 7, 2014 10:14
@lfryc
Copy link
Contributor Author

lfryc commented Nov 7, 2014

@edewit fixed the issue with dependencies and verified with clean build that it works

@edewit
Copy link
Member

edewit commented Nov 7, 2014

👍 works like a charm

@matzew
Copy link
Contributor

matzew commented Nov 13, 2014

@lfryc can you rebase ?

@lfryc lfryc force-pushed the AGPUSH-1025-refactored-logout-after-inactive branch from 1d0edf1 to 1937e6b Compare November 13, 2014 15:36
@lfryc
Copy link
Contributor Author

lfryc commented Nov 13, 2014

@matzew rebazed!

please merge to 1.0.x and master

@sebastienblanc sebastienblanc self-assigned this Nov 13, 2014
@sebastienblanc
Copy link
Member

Do I need to do a bower install because the build is failing for me : [ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:0.0.16:grunt (grunt build) on project unifiedpush-admin-ui: Failed to run task: 'grunt dist --no-color' failed. (error code 1) -> [Help 1]
edit : Fatal error: Unable to find suitable version for angular

@matzew
Copy link
Contributor

matzew commented Nov 13, 2014

👀

"angular-bootstrap": "0.11.0",
"angular-animate": "1.2.26",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these version updates required ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, angular update to 1.2.26 is required, it fixes the animation

@lfryc
Copy link
Contributor Author

lfryc commented Nov 14, 2014

@sebastienblanc could you try mvn clean install -Dfrontend.clean.force ?

@sebastienblanc
Copy link
Member

@lfryc that worked , should we mention that in the readme/doc ?

@sebastienblanc
Copy link
Member

and BTW 👍 it's working

@lfryc
Copy link
Contributor Author

lfryc commented Nov 14, 2014

@sebastienblanc in fact it is kinda "documented" https://github.com/aerogear/aerogear-unifiedpush-server/tree/master/admin-ui#generate-distribution I will add highlight it a bit more :-)

@lfryc lfryc force-pushed the AGPUSH-1025-refactored-logout-after-inactive branch from f3f9bd3 to 368b2d2 Compare November 14, 2014 08:51
@sebastienblanc sebastienblanc merged commit 368b2d2 into aerogear:1.0.x Nov 14, 2014
@lfryc
Copy link
Contributor Author

lfryc commented Nov 14, 2014

Thanks for all the testing, guys!

@lfryc lfryc deleted the AGPUSH-1025-refactored-logout-after-inactive branch November 14, 2014 09:22
@sebastienblanc
Copy link
Member

Landed 6018feb and a596f1c

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants