-
Notifications
You must be signed in to change notification settings - Fork 223
refactored logout-after-inactivity feature #425
refactored logout-after-inactivity feature #425
Conversation
@edewit @sebastienblanc hey guys, would you mind to review? 👀 |
👀 |
I don't get the warning anymore |
Not at all? Interesting - Btw you can use these settings for debugging this stuff (make timeout lower, enable debug log): |
@lfryc don't know what I'm doing wrong, but when I run a
Did you forget a dependency, or am I doing something wrong? |
Right, so I think you are missing ng-idle and angular-animate in bower.json |
Ah, yes, good catch, adding missing deps! On Fri, Nov 7, 2014 at 9:15 AM, Erik Jan de Wit notifications@github.com
|
38a2766
to
1d0edf1
Compare
@edewit fixed the issue with dependencies and verified with clean build that it works |
👍 works like a charm |
@lfryc can you rebase ? |
…h keycloak token periodically AGPUSH-1025
1d0edf1
to
1937e6b
Compare
@matzew rebazed! please merge to |
Do I need to do a |
👀 |
"angular-bootstrap": "0.11.0", | ||
"angular-animate": "1.2.26", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these version updates required ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, angular update to 1.2.26 is required, it fixes the animation
@sebastienblanc could you try |
@lfryc that worked , should we mention that in the readme/doc ? |
and BTW 👍 it's working |
@sebastienblanc in fact it is kinda "documented" https://github.com/aerogear/aerogear-unifiedpush-server/tree/master/admin-ui#generate-distribution I will add highlight it a bit more :-) |
f3f9bd3
to
368b2d2
Compare
Thanks for all the testing, guys! |
https://issues.jboss.org/browse/AGPUSH-1025
merge to
1.0.x
andmaster