Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Apns cleanup #436

Merged
merged 2 commits into from Nov 19, 2014
Merged

Apns cleanup #436

merged 2 commits into from Nov 19, 2014

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Nov 18, 2014

Removing the .withNoErrorDection(), since that was a work-around for notnoop/java-apns#144

This fixes the root of https://issues.jboss.org/browse/AGPUSH-1087

Besides that, I am also lowering the logging on the messageSent of the anonymous ApnsDelegateAdapter implementation.

This needs to go to our master and 1.0.x branches

@matzew
Copy link
Contributor Author

matzew commented Nov 18, 2014

@corinnekrych can you test?
Here is how to test:

  1. Create a variant with your Production certificate.
  2. upload (via curl) the DEVELOPEMENT token from your tests
  3. upload (via curl) the PRODUCTION token from your tests

Once the production variant has these two tokens (make sure the DEV token is uploaded before the PROD token), send a message.

Expected result: message delivered to your device, that has the PROD token

@matzew
Copy link
Contributor Author

matzew commented Nov 18, 2014

@sebastienblanc since I was on the class :) I did some lowering of the logging, since invoked on every token. please let me know what you think

@matzew matzew changed the title Apn scleanup Apns cleanup Nov 18, 2014
@sebastienblanc
Copy link
Member

@matzew wrt the logging 👍 :)

@corinnekrych
Copy link
Contributor

@matzew tested it with HelloWorld iOS app and PROD variant.
register DEV ipad mini
register PROD iphone
send message via admin ui
message received on iphone

+1 to merge

@sebastienblanc
Copy link
Member

Landed 20a076f and 042d7bd

@sebastienblanc sebastienblanc deleted the APNScleanup branch November 25, 2014 10:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants