This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
adding logback + slf4j logging #507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an be solved by jboss-deployment-structure.xml)
| @@ -46,23 +46,23 @@ public void info(String message){ | |||
| } | |||
|
|
|||
| public void warning(String message){ | |||
| AeroGearLogger.logger.log(Level.WARNING, format(message)); | |||
| AeroGearLogger.logger.warn(format(message)); | |||
There was a problem hiding this comment.
just wondering, w/ slf4j do we still need the custom format() ? I hope/think that's done by the slf4j logging library
There was a problem hiding this comment.
yes ... it is true .. I changed it
|
@IvanGurtler thanks a lot, will do some tests/tweaks on this next week. But thanks for contributing ! |
Closed
|
@IvanGurtler I have created this PR, containing your commints + a first draft of my changes. closing this one, since the other PR contains still you fixes :-) Thanks again for sending us the PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing on EAP6.3 (wildfly problems can be solved by jboss-deployment-structure.xml ... but not tested on wildfly)