Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Change REST endpoints response type from "text/plain" to "application/json" with empty JSON body #541

Merged
merged 2 commits into from May 5, 2015

Conversation

idelpivnitskiy
Copy link
Member

See https://issues.jboss.org/browse/AGPUSH-1376

@lfryc I think that we may do the same for /registry/device/importer/. WDYT?

@lfryc
Copy link
Contributor

lfryc commented May 4, 2015

@idelpivnitskiy Yes, that one should respond with JSON as well.

@lfryc
Copy link
Contributor

lfryc commented May 4, 2015

👍 I've tested this and works fine!

@matzew
Copy link
Contributor

matzew commented May 4, 2015

@idelpivnitskiy wana address this in this PR or in a different one?

@idelpivnitskiy
Copy link
Member Author

@matzew if it possible to rename JIRA issue I could do it here. If not, we may create a new ticket

@matzew
Copy link
Contributor

matzew commented May 4, 2015

can you create a sub task?
that should be good enough

On Mon, May 4, 2015 at 4:25 PM, Idel Pivnitskiy notifications@github.com
wrote:

@matzew https://github.com/matzew if it possible to rename JIRA issue I
could do it here. If not, we may create a new ticket


Reply to this email directly or view it on GitHub
#541 (comment)
.

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

@idelpivnitskiy
Copy link
Member Author

I've created sub-task https://issues.jboss.org/browse/AGPUSH-1396
Should I send a new PR for this?

@matzew
Copy link
Contributor

matzew commented May 5, 2015

feel free to include in this PR - that's totally fine :-)

On Tue, May 5, 2015 at 2:56 AM, Idel Pivnitskiy notifications@github.com
wrote:

I've created sub-task https://issues.jboss.org/browse/AGPUSH-1396
Should I send a new PR for this?


Reply to this email directly or view it on GitHub
#541 (comment)
.

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

@idelpivnitskiy idelpivnitskiy changed the title Change /sender REST endpoint response type to application/json with empt... Change REST endpoints response type from "text/plain" to "application/json" with empty JSON body May 5, 2015
@idelpivnitskiy
Copy link
Member Author

@lfryc @matzew done :)

@lfryc
Copy link
Contributor

lfryc commented May 5, 2015

👍

matzew added a commit that referenced this pull request May 5, 2015
Change REST endpoints response type from "text/plain" to "application/json" with empty JSON body
@matzew matzew merged commit f8500ee into aerogear:master May 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants