reintroduced Installation List with search capability AGPUSH-1406

[lfryc]

https://issues.jboss.org/browse/AGPUSH-1406

Summary:

• the device list is conditionally presented to a user in the Variant detail
  • the device list has: search capability
  • ...pagination
  • ability to enable/disable device
• the client device registration snippet is not shown when there are registered devices (but user can click to reveal it by hitting a link)
• and vice versa, no device list is shown when there are "No installations yet" and client device registration snippet is presented then

Note:

• I had to extend REST endpoint by one optional parameter "search" that allows full text search in some comment installation properties

Testing:

• test that features above works as you would expect

A mockup I used as a base for impl: http://andresgalante.com/ups-console/app-detail-variants.html

[lfryc]

@sebastienblanc would you mind to 👀 this? 🏈

[sebastienblanc]

👀

[matzew]

+1 tested and works fine

[matzew]

@lfryc @sebastienblanc I think this needs a rebase

[lfryc]

rebasing

[lfryc]

@matzew rebased on latest master

[matzew]

+1

[lfryc]

Once merged, please take a look at #579

[sebastienblanc]

Working as expected :) , one remark, there is a text + link just before the table This is a list of devices using this variable. To see installation instructions and code snippet click here once on the snippet section there is not really a way to go back to the device list (unless you collapse the variant and open it again), maybe we could add the link to the device list also on the snippet section ?

[matzew]

@sebastienblanc is that really needed ?

@andresgalante any comments?

[lfryc]

if you click on "To see installation instructions and code snippet click here"...
the snippets are expanded, but the device list remains still there, it is now under the snippets
is that what you wanted @sebastienblanc ?

[sebastienblanc]

Oh Sorry, did not saw it was under the snippets :), then it's all okay :+1

On Tue, Jun 2, 2015 at 1:56 PM, Lukáš Fryč notifications@github.com wrote:

if you click on "To see installation instructions and code snippet click
here"...
the snippets are expanded, but the device list remains still there, it is
now under the snippets
is that what you wanted @sebastienblanc
https://github.com/sebastienblanc ?

—
Reply to this email directly or view it on GitHub
#577 (comment)
.

[lfryc]

Landed 🚀