Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

UI for Pending status of notification sending process AGPUSH-1441 #589

Merged
merged 1 commit into from
Jun 5, 2015
Merged

UI for Pending status of notification sending process AGPUSH-1441 #589

merged 1 commit into from
Jun 5, 2015

Conversation

lfryc
Copy link
Contributor

@lfryc lfryc commented Jun 5, 2015

https://issues.jboss.org/browse/AGPUSH-1441

Testing:

  • create several variants, register some devices and then push
  • first you can see just status Pending when table refreshes after push, but later it changes to Success/Failed
  • this UI suffers from following issue though: https://issues.jboss.org/browse/AGPUSH-1445

@lfryc
Copy link
Contributor Author

lfryc commented Jun 5, 2015

@sebastienblanc mind to test this? 🏈

@matzew
Copy link
Contributor

matzew commented Jun 5, 2015

@lfryc

running the tests:

Results :

Failed tests:
  TestMetricsCollector.test:106 expected:<2> but was:<0>

Tests run: 33, Failures: 1, Errors: 0, Skipped: 2

@matzew
Copy link
Contributor

matzew commented Jun 5, 2015

@lfryc Travis has same error

@lfryc
Copy link
Contributor Author

lfryc commented Jun 5, 2015

Fixed and rebased on master @matzew

@matzew
Copy link
Contributor

matzew commented Jun 5, 2015

👍 tested and works fine!

@sebastienblanc
Copy link
Member

awesome stuff !
works here as well, tested with successful and failed, both start with pending.
merging

@sebastienblanc sebastienblanc merged commit 8761d0e into aerogear:master Jun 5, 2015
@lfryc lfryc deleted the AGPUSH-1441-pending branch June 5, 2015 12:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lfryc @matzew @sebastienblanc