Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

activity screen - do not show blank slate when search is active AGPUSH-1500 #676

Merged

Conversation

lfryc
Copy link
Contributor

@lfryc lfryc commented Jan 27, 2016

https://issues.jboss.org/browse/AGPUSH-1500

I've introduced a helper isSearchActive() that is now a condition for showing blank slate.

Besides that I've fixed the Register Device button also on Activity page (was fixed before on Analytics: https://github.com/aerogear/aerogear-unifiedpush-server/blob/1.1.x-dev/admin-ui/app/components/app-detail/include/analytics.html#L97 )

🎯 master and 1.1.x-dev
🚢 deployed at https://upsstaging-aerogearz.rhcloud.com/ag-push/ (standard credentials)
🔨 Testing:

  • try Activity tab with no devices registered (blank slate should be shown)
  • try Activity tab with one device registered (blank slate should be shown)
  • try Activity tab with a message sent (the activity log table should appear)
  • try Activity tab with a message sent, but use search with a non-existent value (activity log table should be visible, but a message "No message matches the given search criteria." will appear - then try to clear search string and a message should appear again)

@lfryc
Copy link
Contributor Author

lfryc commented Jan 27, 2016

This PR replaces #675

@sebastienblanc sebastienblanc merged commit 173abf0 into aerogear:master Jan 27, 2016
@lfryc
Copy link
Contributor Author

lfryc commented Jan 27, 2016

1.1.x-dev: 0bd6f62

master: 173abf0

@lfryc
Copy link
Contributor Author

lfryc commented Jan 27, 2016

Thanks @sebastienblanc !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants