This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Adding support for removing old tokens #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matzew
reviewed
Sep 14, 2016
| @@ -137,6 +139,9 @@ public Response crossOriginForInstallations(@Context HttpHeaders headers) { | |||
| * @param entity {@link Installation} for Device registration | |||
| * @return registered {@link Installation} | |||
| * | |||
| * @requestheader x-ag-old-token the old push service dependant token (ie InstanceID in FCM). | |||
There was a problem hiding this comment.
unfortunaltey, we also need a JavaDoc @param here, since the build is failing :/(
matzew
reviewed
Sep 14, 2016
| @@ -171,6 +177,11 @@ public Response registerInstallation( | |||
| // otherwise we register a new installation: | |||
| logger.trace("Mobile Application on device was launched"); | |||
|
|
|||
| //The token has changed, remove the old one | |||
| if (!oldToken.isEmpty() && !oldToken.equals(entity.getDeviceToken())) { | |||
There was a problem hiding this comment.
why would a device send its current token as the old one ?
There was a problem hiding this comment.
Because the device isn't making a similar check on its end.
| @@ -171,6 +177,11 @@ public Response registerInstallation( | |||
| // otherwise we register a new installation: | |||
| logger.trace("Mobile Application on device was launched"); | |||
|
|
|||
| //The token has changed, remove the old one | |||
| if (!oldToken.isEmpty() && !oldToken.equals(entity.getDeviceToken())) { | |||
| clientInstallationService.removeInstallationForVariantByDeviceToken(variant.getVariantID(), oldToken); | |||
|
@secondsun you can easily test if it breaks, using CURL: 馃榿 |
|
btw. tested with @secondsun @corinnekrych workz! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@matzew @danielpassos 馃憮 ?
@corinnekrych or someone else, can you confirm this doesn't cause any regressions with iOS?