Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

AGSEC-201/203: Move the OAuth2 configuration to aerogear.org #506

Closed
wants to merge 11 commits into from
Closed

AGSEC-201/203: Move the OAuth2 configuration to aerogear.org #506

wants to merge 11 commits into from

Conversation

abstractj
Copy link
Contributor

This is just the start from the series of section for security, I prefer to deliver early and often instead of a gazillion of documentation to review.

To track all the items being created check AGSEC-200.

@danielpassos @matzew @lfryc @cvasilak @secondsun @edewit @corinnekrych you are all invited to review.

Keep in mind that the content will be moved gradually to the new-design branch and I also made sure to keep the ownership of the document.

@abstractj abstractj changed the title AGSEC-201: Move the OAuth2 configuration to aerogear.org AGSEC-201/203: Move the OAuth2 configuration to aerogear.org Feb 24, 2015
@edewit
Copy link
Member

edewit commented Feb 25, 2015

The google description you have here only works for Android. If you take the one from here, that will work for all platforms Android, iOS and Windows.

@corinnekrych
Copy link
Contributor

Google working with iOS is a bit more tricky, @edewit doc is good.
+1 on moving this doc, I also think this ticket should also include cleaning the README instruction (pointing to ag.org instead). Too much info:
https://github.com/aerogear/aerogear-ios-cookbook/tree/master/Shoot#facebook-setup
https://github.com/aerogear/aerogear-android-cookbook/tree/master/ShootAndShare#google-account-setup
and cordova and windows.

@matzew
Copy link
Contributor

matzew commented Feb 25, 2015

I also think this ticket should also include cleaning the README instruction (pointing to ag.org instead). Too much info

@corinnekrych mind filing a separate JIRA / PR for this ?


* [Android client library](http://search.maven.org/#artifactdetails%7Corg.jboss.aerogear%7Caerogear-android-authz%7C2.0.0%7Caar)
* [iOS client library](http://cocoapods.org/?q=aerogearoauth2)
* [Apache Cordova client library](https://github.com/aerogear/aerogear-oauth2-cordova/releases/tag/v1.0.2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matzew updated

@matzew
Copy link
Contributor

matzew commented Feb 25, 2015

The google description you have here only works for Android. If you take the one from here, that will work for all platforms Android, iOS and Windows.

Sounds good using that info from the cookbook.

One question: Should the cookbook just than link to the site, for the setup ? I think it would make sense to have one, centralized configuration page.

@abstractj++

@edewit
Copy link
Member

edewit commented Feb 25, 2015

@matzew right, after this PR is merged we can update the cookbooks to point to the site

@matzew
Copy link
Contributor

matzew commented Feb 25, 2015

awesome

On Wed, Feb 25, 2015 at 9:24 AM, Erik Jan de Wit notifications@github.com
wrote:

@matzew https://github.com/matzew right, after this PR is merged we can
update the cookbooks to point to the site


Reply to this email directly or view it on GitHub
#506 (comment).

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

@abstractj
Copy link
Contributor Author

@edewit I will do the changes suggested by you today

@matzew Regarding the readme updates, that's was my plan after get some feedback here, anyways thanks @corinnekrych for creating those jiras. I created https://issues.jboss.org/browse/AGSEC-205 and attached the related Jiras there.

I will review all the comments here this morning and update this PR. Thanks in advance for the feedback.

@matzew
Copy link
Contributor

matzew commented Feb 25, 2015

cool beans! great seeing this initiative, @abstractj

On Wed, Feb 25, 2015 at 10:23 AM, Bruno Oliveira notifications@github.com
wrote:

@edewit https://github.com/edewit I will do the changes suggested by
you today

@matzew https://github.com/matzew Regarding the readme updates, that's
was my plan after get some feedback here, anyways thanks @corinnekrych
https://github.com/corinnekrych for creating those jiras. I created
https://issues.jboss.org/browse/AGSEC-205 and attached the related Jiras
there.

I will review all the comments here this morning and update this PR.
Thanks in advance for the feedback.


Reply to this email directly or view it on GitHub
#506 (comment).

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

* [AeroGear Two-Factor Authentication with OTP as Cordova Plugin](aerogear-cordova/AerogearCordovaOTP)

* OAuth2
1. [Basic steps](security/oauth2-basic-steps)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer something like Getting Started with various OAuth2 Providers (Basic Steps sounds too general imo)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lfryc that's the idea, be general, various OAuth2 providers is general in the same way. Most of the guides outside make use of this sentence.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Getting Started with various OAuth2 Providers (Keycloak, Facebook, Google)?

I just didn't expect what that link opened, but we may reiterate later on overall structure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lfryc We can always improve later, this is not something definitive. Also, with the new website we gonna have room enough to change. I think more important now is to see if the content looks good and later we can rearrange/move sections.

Bruno Oliveira and others added 10 commits February 25, 2015 15:54
Additional authors:

Petr Stribny <pstribny@redhat.com>
Summers Pittman <secondsun@gmail.com>
Bruno Oliveira <bruno@abstractj.org>
Additional authors:

Matthias Wessendorf <matzew@apache.org>
Christos Vasilakis <cvasilak@gmail.com>
Daniel Passos <daniel@passos.me>
Summers Pittman <secondsun@gmail.com>
Bruno Oliveira <bruno@abstractj.org>
@abstractj
Copy link
Contributor Author

@edewit @corinnekrych updated. Let me know if anything is missing

@edewit
Copy link
Member

edewit commented Feb 25, 2015

👍 like the blur you added on the google logged in use picture

@danielpassos
Copy link
Collaborator

👍

@abstractj
Copy link
Contributor Author

Landed, thank you all

@abstractj abstractj closed this Feb 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants