Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule methods should implement interface #98

Closed
ankithans opened this issue Jun 30, 2021 · 1 comment · Fixed by #103
Closed

Rule methods should implement interface #98

ankithans opened this issue Jun 30, 2021 · 1 comment · Fixed by #103
Assignees
Labels
enhancement New feature or request invalid This doesn't seem right
Projects

Comments

@ankithans
Copy link
Member

To make it easy for adding more custom rules to validator, rules methods should implement an interface.
we should have the same interface and the same function. Without that there will be no way to add rule to validator. This two methods should be the same method

Currently

lengthRule implements - validateLength
MustExistRule implements - validateMustExist

@ankithans ankithans added enhancement New feature or request invalid This doesn't seem right labels Jun 30, 2021
@wtrocki
Copy link
Contributor

wtrocki commented Jun 30, 2021

and they should be just validate

@ankithans ankithans added this to To do in Charmil WIP via automation Jun 30, 2021
@ankithans ankithans self-assigned this Jun 30, 2021
@ankithans ankithans moved this from To do to In progress in Charmil WIP Jun 30, 2021
@ankithans ankithans moved this from In progress to Review in progress in Charmil WIP Jul 1, 2021
Charmil WIP automation moved this from Review in progress to Done Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
Charmil WIP
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants