fix: validate rules in loop #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankithans
force-pushed
the
ankithans/issue98
branch
from
ec97030
to
96c7127
Compare
wtrocki
reviewed
Jul 1, 2021
| @@ -10,6 +10,10 @@ import ( | |||
| "github.com/spf13/cobra" | |||
| ) | |||
|
|
|||
| type Rules interface { | |||
wtrocki
reviewed
Jul 1, 2021
| @@ -10,6 +10,10 @@ import ( | |||
| "github.com/spf13/cobra" | |||
| ) | |||
|
|
|||
| type Rules interface { | |||
| Validate() []validator.ValidationError | |||
There was a problem hiding this comment.
Wrap error aray in result structure for other elements
There was a problem hiding this comment.
actually lets leave it likt this
wtrocki
approved these changes
Jul 1, 2021
|
Lets release this /create github release v0.1.0 |
|
Draft release. Changes required? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #98
Closes #93
Closes #53
Description
RuleinterfaceType of change