New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor core #154
Refactor core #154
Conversation
@ankithans Starter have opiniated libraries from rhoas bringing them to core might be challenging. |
I thino this PR has tons of good changed:
I will leave others for now as this PR might be too large to deal with all at the same time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go after cleanup and rebase.
World class job
@namit-chandwani we are missing only config |
yes it does these changes and next after this merge I will make these new features in core - running with starter example. |
I will keep core small, well tested, well documented. PRs to core should be small and targeted. |
Good to go! |
so are you recommending to implement/test these additions to core in this PR? we can do that as well! |
No I recommend to minimize amount of untested code landing into core without issues/discussion. Let's merge this but I want us to admin that we keeping core small/useful and functional |
Description
Extract packages from starter and put them into charmil-core
Next Step would be to make a starter CLI able to run all these packages!
after that a starter template -> then CLI tool
I will provide documentation for all the packages, once i get them running in the example